refactor(api): extract timeline allocation mutation payload helpers

packages/api/src/router/timeline-allocation-mutations.ts

@@ -22,12 +22,13 @@ import {
 import { managerProcedure, requirePermission } from "../trpc.js";
 import {
   assertTimelineDateRangeValid,
+  buildTimelineAllocationEntryUpdate,
   buildTimelineAllocationMetadata,
   buildTimelineAllocationUpdateAuditChanges,
   buildTimelineBatchShiftAuditChanges,
-  buildTimelineQuickAssignMetadata,
-  calculateTimelineAllocationPercentage,
+  buildTimelineQuickAssignAssignmentInput,
   shiftTimelineAllocationWindow,
+  validateTimelineAllocationDateRanges,
 } from "./timeline-allocation-mutation-support.js";
 import { calculateTimelineAllocationDailyCost } from "./timeline-cost-support.js";
 
@@ -81,21 +82,14 @@ export const timelineAllocationMutationProcedures = {
           tx as unknown as Parameters<typeof updateAllocationEntry>[0],
           {
             id: input.allocationId,
-            demandRequirementUpdate: {
+            ...buildTimelineAllocationEntryUpdate({
               hoursPerDay: newHoursPerDay,
               startDate: newStartDate,
               endDate: newEndDate,
               metadata: newMeta,
-              ...(input.role !== undefined ? { role: input.role } : {}),
-            },
-            assignmentUpdate: {
-              hoursPerDay: newHoursPerDay,
-              startDate: newStartDate,
-              endDate: newEndDate,
               dailyCostCents: newDailyCostCents,
-              metadata: newMeta,
-              ...(input.role !== undefined ? { role: input.role } : {}),
-            },
+              role: input.role,
+            }),
           },
         );
 
@@ -147,24 +141,13 @@ export const timelineAllocationMutationProcedures = {
       requirePermission(ctx, PermissionKey.MANAGE_ALLOCATIONS);
       assertTimelineDateRangeValid(input.startDate, input.endDate);
 
-      const percentage = calculateTimelineAllocationPercentage(input.hoursPerDay);
-      const metadata = buildTimelineQuickAssignMetadata("quickAssign");
-
       const allocation = await ctx.db.$transaction(async (tx) => {
         const assignment = await createAssignment(
           tx as unknown as Parameters<typeof createAssignment>[0],
-          {
-            resourceId: input.resourceId,
-            projectId: input.projectId,
-            startDate: input.startDate,
-            endDate: input.endDate,
-            hoursPerDay: input.hoursPerDay,
-            percentage,
-            role: input.role,
-            roleId: input.roleId ?? undefined,
-            status: input.status,
-            metadata,
-          },
+          buildTimelineQuickAssignAssignmentInput({
+            ...input,
+            source: "quickAssign",
+          }),
         );
 
         return buildSplitAllocationReadModel({
@@ -205,30 +188,17 @@ export const timelineAllocationMutationProcedures = {
     )
     .mutation(async ({ ctx, input }) => {
       requirePermission(ctx, PermissionKey.MANAGE_ALLOCATIONS);
-
-      for (const assignment of input.assignments) {
-        assertTimelineDateRangeValid(assignment.startDate, assignment.endDate);
-      }
+      validateTimelineAllocationDateRanges(input.assignments);
 
       const results = await ctx.db.$transaction(async (tx) => {
         const created = [];
         for (const assignment of input.assignments) {
-          const percentage = calculateTimelineAllocationPercentage(assignment.hoursPerDay);
-          const metadata = buildTimelineQuickAssignMetadata("batchQuickAssign");
-
           const createdAssignment = await createAssignment(
             tx as unknown as Parameters<typeof createAssignment>[0],
-            {
-              resourceId: assignment.resourceId,
-              projectId: assignment.projectId,
-              startDate: assignment.startDate,
-              endDate: assignment.endDate,
-              hoursPerDay: assignment.hoursPerDay,
-              percentage,
-              role: assignment.role,
-              status: assignment.status,
-              metadata,
-            },
+            buildTimelineQuickAssignAssignmentInput({
+              ...assignment,
+              source: "batchQuickAssign",
+            }),
           );
           created.push(createdAssignment);
         }