refactor(web): extract allocation release effects

apps/web/src/hooks/useTimelineDrag.ts

@@ -11,7 +11,6 @@ import {
   scheduleLivePreview,
   type LivePreviewSession,
 } from "./timelineLivePreview.js";
-import { buildAllocationMovedSnapshot } from "./timelineAllocationFinalize.js";
 import {
   finalizeAllocationMultiDrag,
   isAllocationMultiSelected,
@@ -19,9 +18,9 @@ import {
   updateAllocationMultiDrag,
 } from "./timelineAllocationMultiDrag.js";
 import { beginAllocationMultiDragSession } from "./timelineAllocationMultiDragSession.js";
-import { resolveAllocationRelease } from "./timelineAllocationRelease.js";
 import { createAllocationDragState } from "./timelineAllocationDragState.js";
 import { beginAllocationDragSession } from "./timelineAllocationDragSession.js";
+import { finalizeAllocationReleaseEffects } from "./timelineAllocationReleaseEffects.js";
 import { cleanupTimelineDragState } from "./timelineDragCleanup.js";
 import { resolveAllocationDragPosition, resolveProjectDragPosition } from "./timelineDragPosition.js";
 import { attachDocumentMouseDrag } from "./timelineDocumentDrag.js";
@@ -640,75 +639,22 @@ export function useTimelineDrag({
         attachDrag: attachDocumentMouseDrag,
         updatePosition: updateAllocationDragPosition,
         finalize: (clientX) => {
-          updateAllocationDragPosition(clientX);
-          const alloc = allocDragRef.current;
-          const release = resolveAllocationRelease(alloc, {
+          void finalizeAllocationReleaseEffects({
+            clientX,
+            allocRef: allocDragRef,
+            previewRef: allocPreviewRef,
+            updatePosition: updateAllocationDragPosition,
             clickThresholdPx: DRAG_CLICK_THRESHOLD_PX,
             wasShift,
+            onShiftClick: onShiftClickAllocRef.current,
+            onBlockClick: onBlockClickRef.current,
+            pendingSnapshotRef,
+            pendingOptimisticAllocationIdRef,
+            setOptimisticAllocations,
+            extractAllocationFragment: extractAllocFragmentMutation.mutateAsync,
+            updateAllocation: updateAllocMutation.mutate,
+            clearPendingOptimisticAllocation,
           });
-          if (release.kind === "ignore") return;
-
-          if (release.preservePreview) {
-            preserveLivePreview(allocPreviewRef.current);
-          }
-          clearLivePreview(allocPreviewRef.current);
-          allocPreviewRef.current = null;
-
-          if (release.kind === "shift-click") {
-            onShiftClickAllocRef.current?.(release.allocationId);
-          } else if (release.kind === "click") {
-            onBlockClickRef.current?.(release.clickInfo);
-          } else if (release.kind === "mutation") {
-            const { mutationPlan } = release;
-            const {
-              activeAllocationId,
-              currentStartDate,
-              currentEndDate,
-              baseMutationAllocationId,
-              requiresExtraction,
-              pendingSnapshot,
-            } = mutationPlan;
-
-            pendingSnapshotRef.current = pendingSnapshot;
-            pendingOptimisticAllocationIdRef.current = activeAllocationId;
-            setOptimisticAllocations((prev) => {
-              const next = new Map(prev);
-              next.set(activeAllocationId, {
-                startDate: currentStartDate,
-                endDate: currentEndDate,
-              });
-              return next;
-            });
-            void (async () => {
-              try {
-                let mutationAllocationId = baseMutationAllocationId;
-
-                if (requiresExtraction) {
-                  const extracted = await extractAllocFragmentMutation.mutateAsync({
-                    allocationId: mutationAllocationId,
-                    startDate: alloc.originalStartDate!,
-                    endDate: alloc.originalEndDate!,
-                  });
-                  mutationAllocationId = extracted.extractedAllocationId;
-                }
-
-                pendingSnapshotRef.current = pendingSnapshotRef.current
-                  ? {
-                      ...pendingSnapshotRef.current,
-                      mutationAllocationId,
-                    }
-                  : null;
-
-                updateAllocMutation.mutate({
-                  allocationId: mutationAllocationId,
-                  startDate: currentStartDate,
-                  endDate: currentEndDate,
-                });
-              } catch {
-                clearPendingOptimisticAllocation(activeAllocationId);
-              }
-            })();
-          }
 
           allocDragRef.current = INITIAL_ALLOC_DRAG;
           setAllocDragState(INITIAL_ALLOC_DRAG);