fix(sanity): resolve 15 gaps from sanity check audit (G-01 through G-15)
- G-01: ProjectWizard renders blueprint fieldDefs with DynamicFieldInput component - G-02: Blueprint rolePresets validated via RolePresetsSchema in wizard; API keeps loose schema - G-03: ProjectWizard step 2/3 validation (role, hoursPerDay, headcount required) - G-04: EstimateWizard validates baseCurrency and demand line cost rates - G-05: Project lifecycle transition guards with ALLOWED_TRANSITIONS map - G-06: Blueprint validator extended for minLength/maxLength/pattern and DATE range checks - G-07: assertBlueprintDynamicFields merges global blueprint fieldDefs into validation - G-08: (tracked — chapter managed dropdown; deferred to backend ticket) - G-09: JSDoc added to lcrCents/ucrCents clarifying LCR/UCR terminology - G-10: Dispo route redirect already in place — closed as done - G-11: packages/ui empty by design — closed as documented - G-12: @deprecated JSDoc added to CreateAllocationSchema and UpdateAllocationSchema - G-13: ProjectWizard review step enhanced with blueprint name, field values, skills, assignments - G-14: ProjectWizard handleSubmit collects per-item warnings instead of silent swallowing - G-15: Vacation cancel reverses usedDays entitlement for APPROVED ANNUAL/OTHER vacations Tests: all 1575 passing (1 pre-existing failure in insights-summary unrelated to these changes) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -84,7 +84,41 @@ export function validateCustomFields(
|
||||
}
|
||||
break;
|
||||
|
||||
// TEXT, TEXTAREA, DATE — no structural validation beyond required
|
||||
case FieldType.TEXT:
|
||||
case FieldType.TEXTAREA: {
|
||||
const strVal = String(value);
|
||||
const v = def.validation;
|
||||
if (v) {
|
||||
if (v.minLength !== undefined && strVal.length < v.minLength) {
|
||||
errors.push({ key: def.key, message: v.message ?? `${def.label} must be at least ${v.minLength} characters` });
|
||||
}
|
||||
if (v.maxLength !== undefined && strVal.length > v.maxLength) {
|
||||
errors.push({ key: def.key, message: v.message ?? `${def.label} must be at most ${v.maxLength} characters` });
|
||||
}
|
||||
if (v.pattern !== undefined && !new RegExp(v.pattern).test(strVal)) {
|
||||
errors.push({ key: def.key, message: v.message ?? `${def.label} has an invalid format` });
|
||||
}
|
||||
}
|
||||
break;
|
||||
}
|
||||
|
||||
case FieldType.DATE: {
|
||||
const dateVal = new Date(String(value));
|
||||
if (isNaN(dateVal.getTime())) {
|
||||
errors.push({ key: def.key, message: `${def.label} must be a valid date` });
|
||||
} else {
|
||||
const v = def.validation;
|
||||
if (v) {
|
||||
if (v.min !== undefined && dateVal.getTime() < new Date(v.min).getTime()) {
|
||||
errors.push({ key: def.key, message: v.message ?? `${def.label} must not be before ${new Date(v.min).toLocaleDateString()}` });
|
||||
}
|
||||
if (v.max !== undefined && dateVal.getTime() > new Date(v.max).getTime()) {
|
||||
errors.push({ key: def.key, message: v.message ?? `${def.label} must not be after ${new Date(v.max).toLocaleDateString()}` });
|
||||
}
|
||||
}
|
||||
}
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user