refactor(api): extract assistant chat orchestration
This commit is contained in:
@@ -0,0 +1,295 @@
|
||||
import { beforeEach, describe, expect, it, vi } from "vitest";
|
||||
|
||||
vi.mock("../ai-client.js", () => ({
|
||||
loggedAiCall: vi.fn(async (_provider, _model, _promptLength, fn: () => Promise<unknown>) => fn()),
|
||||
parseAiError: vi.fn((error: unknown) => error instanceof Error ? error.message : String(error)),
|
||||
}));
|
||||
|
||||
vi.mock("../lib/audit.js", () => ({
|
||||
createAuditEntry: vi.fn().mockResolvedValue(undefined),
|
||||
}));
|
||||
|
||||
vi.mock("../lib/content-filter.js", () => ({
|
||||
checkAiOutput: vi.fn((content: string) => ({ clean: true, redacted: content })),
|
||||
}));
|
||||
|
||||
vi.mock("../lib/logger.js", () => ({
|
||||
logger: {
|
||||
debug: vi.fn(),
|
||||
info: vi.fn(),
|
||||
warn: vi.fn(),
|
||||
error: vi.fn(),
|
||||
},
|
||||
}));
|
||||
|
||||
vi.mock("../router/assistant-approvals.js", () => {
|
||||
class AssistantApprovalStorageUnavailableError extends Error {}
|
||||
|
||||
return {
|
||||
AssistantApprovalStorageUnavailableError,
|
||||
createPendingAssistantApproval: vi.fn(),
|
||||
toApprovalPayload: vi.fn((approval: { id: string; toolName: string; summary: string }, status: string) => ({
|
||||
id: approval.id,
|
||||
toolName: approval.toolName,
|
||||
summary: approval.summary,
|
||||
status,
|
||||
})),
|
||||
};
|
||||
});
|
||||
|
||||
vi.mock("../router/assistant-insights.js", () => ({
|
||||
buildAssistantInsight: vi.fn(),
|
||||
}));
|
||||
|
||||
vi.mock("../router/assistant-tools.js", () => ({
|
||||
MUTATION_TOOLS: new Set(["create_project"]),
|
||||
executeTool: vi.fn(),
|
||||
}));
|
||||
|
||||
import { createAuditEntry } from "../lib/audit.js";
|
||||
import { logger } from "../lib/logger.js";
|
||||
import { checkAiOutput } from "../lib/content-filter.js";
|
||||
import {
|
||||
AssistantApprovalStorageUnavailableError,
|
||||
createPendingAssistantApproval,
|
||||
} from "../router/assistant-approvals.js";
|
||||
import { ASSISTANT_CONFIRMATION_PREFIX } from "../router/assistant-confirmation.js";
|
||||
import { buildAssistantInsight } from "../router/assistant-insights.js";
|
||||
import { runAssistantToolLoop } from "../router/assistant-chat-loop.js";
|
||||
import { executeTool } from "../router/assistant-tools.js";
|
||||
|
||||
function createClient(...responses: unknown[]) {
|
||||
return {
|
||||
chat: {
|
||||
completions: {
|
||||
create: vi.fn()
|
||||
.mockImplementation(async () => {
|
||||
const next = responses.shift();
|
||||
if (!next) {
|
||||
throw new Error("No mock AI response configured");
|
||||
}
|
||||
return next;
|
||||
}),
|
||||
},
|
||||
},
|
||||
};
|
||||
}
|
||||
|
||||
function createLoopInput(overrides: Partial<Parameters<typeof runAssistantToolLoop>[0]> = {}) {
|
||||
return {
|
||||
db: {} as never,
|
||||
dbUserId: "user_1",
|
||||
client: createClient({
|
||||
choices: [{ message: { content: "ok" } }],
|
||||
}),
|
||||
provider: "openai",
|
||||
model: "gpt-4o-mini",
|
||||
maxTokens: 2000,
|
||||
temperature: 0.4,
|
||||
openaiMessages: [{ role: "system", content: "system" }],
|
||||
availableTools: [],
|
||||
toolCtx: {
|
||||
db: {} as never,
|
||||
userId: "user_1",
|
||||
userRole: "USER",
|
||||
permissions: new Set(),
|
||||
session: null,
|
||||
dbUser: null,
|
||||
roleDefaults: null,
|
||||
},
|
||||
userId: "user_1",
|
||||
conversationId: "conv_1",
|
||||
collectedActions: [],
|
||||
collectedInsights: [],
|
||||
maxToolIterations: 8,
|
||||
...overrides,
|
||||
};
|
||||
}
|
||||
|
||||
describe("assistant chat loop", () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
vi.mocked(checkAiOutput).mockImplementation((content: string) => ({ clean: true, redacted: content }));
|
||||
vi.mocked(buildAssistantInsight).mockReturnValue(undefined);
|
||||
});
|
||||
|
||||
it("returns a confirmation response instead of executing mutation tools immediately", async () => {
|
||||
vi.mocked(createPendingAssistantApproval).mockResolvedValue({
|
||||
id: "approval_1",
|
||||
toolName: "create_project",
|
||||
summary: "create project (name=Apollo)",
|
||||
} as never);
|
||||
|
||||
const result = await runAssistantToolLoop(createLoopInput({
|
||||
client: createClient({
|
||||
choices: [{
|
||||
message: {
|
||||
tool_calls: [{
|
||||
id: "call_1",
|
||||
function: {
|
||||
name: "create_project",
|
||||
arguments: "{\"name\":\"Apollo\"}",
|
||||
},
|
||||
}],
|
||||
},
|
||||
}],
|
||||
}),
|
||||
}));
|
||||
|
||||
expect(result).toMatchObject({
|
||||
role: "assistant",
|
||||
content: `${ASSISTANT_CONFIRMATION_PREFIX} create project (name=Apollo). Bitte bestätigen.`,
|
||||
approval: {
|
||||
id: "approval_1",
|
||||
toolName: "create_project",
|
||||
status: "pending",
|
||||
},
|
||||
});
|
||||
expect(executeTool).not.toHaveBeenCalled();
|
||||
expect(createAuditEntry).toHaveBeenCalledWith(expect.objectContaining({
|
||||
entityName: "create_project",
|
||||
summary: "AI tool blocked pending confirmation: create_project",
|
||||
}));
|
||||
});
|
||||
|
||||
it("continues after read-only tool calls and returns collected actions and insights", async () => {
|
||||
vi.mocked(executeTool).mockResolvedValue({
|
||||
content: "{\"resources\":1}",
|
||||
data: { resources: 1 },
|
||||
action: { type: "navigate", href: "/resources" },
|
||||
} as never);
|
||||
vi.mocked(buildAssistantInsight).mockReturnValue({
|
||||
kind: "holiday_region",
|
||||
title: "Berlin",
|
||||
subtitle: "Resolved public holiday set",
|
||||
metrics: [{ label: "Resolved holidays", value: "1" }],
|
||||
});
|
||||
|
||||
const result = await runAssistantToolLoop(createLoopInput({
|
||||
client: createClient(
|
||||
{
|
||||
choices: [{
|
||||
message: {
|
||||
tool_calls: [{
|
||||
id: "call_1",
|
||||
function: {
|
||||
name: "search_resources",
|
||||
arguments: "{\"query\":\"Alice\"}",
|
||||
},
|
||||
}],
|
||||
},
|
||||
}],
|
||||
},
|
||||
{
|
||||
choices: [{ message: { content: "Hier ist die passende Resource." } }],
|
||||
},
|
||||
),
|
||||
}));
|
||||
|
||||
expect(result).toMatchObject({
|
||||
content: "Hier ist die passende Resource.",
|
||||
actions: [{ type: "navigate", href: "/resources" }],
|
||||
insights: [{
|
||||
kind: "holiday_region",
|
||||
title: "Berlin",
|
||||
}],
|
||||
});
|
||||
expect(executeTool).toHaveBeenCalledWith(
|
||||
"search_resources",
|
||||
"{\"query\":\"Alice\"}",
|
||||
expect.objectContaining({ userId: "user_1" }),
|
||||
);
|
||||
expect(createAuditEntry).toHaveBeenCalledWith(expect.objectContaining({
|
||||
entityName: "search_resources",
|
||||
summary: "AI executed tool: search_resources",
|
||||
}));
|
||||
});
|
||||
|
||||
it("redacts unsafe AI output before returning it", async () => {
|
||||
vi.mocked(checkAiOutput).mockReturnValue({
|
||||
clean: false,
|
||||
redacted: "[redacted]",
|
||||
});
|
||||
|
||||
const result = await runAssistantToolLoop(createLoopInput({
|
||||
client: createClient({
|
||||
choices: [{ message: { content: "API key is sk-secret" } }],
|
||||
}),
|
||||
}));
|
||||
|
||||
expect(result.content).toBe("[redacted]");
|
||||
expect(logger.warn).toHaveBeenCalledWith(
|
||||
{ userId: "user_1" },
|
||||
"AI output contained sensitive content — redacted before delivery",
|
||||
);
|
||||
expect(createAuditEntry).toHaveBeenCalledWith(expect.objectContaining({
|
||||
entityName: "AiOutputRedacted",
|
||||
}));
|
||||
});
|
||||
|
||||
it("returns a stable fallback after too many tool-call iterations", async () => {
|
||||
vi.mocked(executeTool).mockResolvedValue({
|
||||
content: "{\"ok\":true}",
|
||||
data: { ok: true },
|
||||
} as never);
|
||||
|
||||
const result = await runAssistantToolLoop(createLoopInput({
|
||||
client: createClient(
|
||||
{
|
||||
choices: [{
|
||||
message: {
|
||||
tool_calls: [{
|
||||
id: "call_1",
|
||||
function: {
|
||||
name: "search_resources",
|
||||
arguments: "{\"query\":\"A\"}",
|
||||
},
|
||||
}],
|
||||
},
|
||||
}],
|
||||
},
|
||||
{
|
||||
choices: [{
|
||||
message: {
|
||||
tool_calls: [{
|
||||
id: "call_2",
|
||||
function: {
|
||||
name: "search_resources",
|
||||
arguments: "{\"query\":\"B\"}",
|
||||
},
|
||||
}],
|
||||
},
|
||||
}],
|
||||
},
|
||||
),
|
||||
maxToolIterations: 2,
|
||||
}));
|
||||
|
||||
expect(result.content).toBe("I had to stop after too many tool calls. Please try a simpler question.");
|
||||
});
|
||||
|
||||
it("degrades mutation confirmations when approval storage is unavailable", async () => {
|
||||
vi.mocked(createPendingAssistantApproval).mockRejectedValue(
|
||||
new AssistantApprovalStorageUnavailableError("missing table"),
|
||||
);
|
||||
|
||||
const result = await runAssistantToolLoop(createLoopInput({
|
||||
client: createClient({
|
||||
choices: [{
|
||||
message: {
|
||||
tool_calls: [{
|
||||
id: "call_1",
|
||||
function: {
|
||||
name: "create_project",
|
||||
arguments: "{\"name\":\"Apollo\"}",
|
||||
},
|
||||
}],
|
||||
},
|
||||
}],
|
||||
}),
|
||||
}));
|
||||
|
||||
expect(result.content).toContain("Schreibende Assistant-Aktionen sind gerade nicht verfuegbar");
|
||||
expect(executeTool).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,179 @@
|
||||
import { beforeEach, describe, expect, it, vi } from "vitest";
|
||||
|
||||
vi.mock("../lib/audit.js", () => ({
|
||||
createAuditEntry: vi.fn().mockResolvedValue(undefined),
|
||||
}));
|
||||
|
||||
vi.mock("../router/assistant-approvals.js", () => ({
|
||||
clearPendingAssistantApproval: vi.fn().mockResolvedValue(undefined),
|
||||
consumePendingAssistantApproval: vi.fn(),
|
||||
toApprovalPayload: vi.fn((approval: { id: string; toolName: string; summary: string }, status: string) => ({
|
||||
id: approval.id,
|
||||
toolName: approval.toolName,
|
||||
summary: approval.summary,
|
||||
status,
|
||||
})),
|
||||
}));
|
||||
|
||||
vi.mock("../router/assistant-confirmation.js", () => ({
|
||||
canExecuteMutationTool: vi.fn(),
|
||||
isCancellationReply: vi.fn(),
|
||||
parseToolArguments: vi.fn(() => ({ name: "Apollo" })),
|
||||
}));
|
||||
|
||||
vi.mock("../router/assistant-insights.js", () => ({
|
||||
buildAssistantInsight: vi.fn(),
|
||||
}));
|
||||
|
||||
vi.mock("../router/assistant-tool-results.js", () => ({
|
||||
readToolError: vi.fn(),
|
||||
readToolSuccessMessage: vi.fn(),
|
||||
}));
|
||||
|
||||
vi.mock("../router/assistant-tools.js", () => ({
|
||||
executeTool: vi.fn(),
|
||||
}));
|
||||
|
||||
import { createAuditEntry } from "../lib/audit.js";
|
||||
import {
|
||||
clearPendingAssistantApproval,
|
||||
consumePendingAssistantApproval,
|
||||
} from "../router/assistant-approvals.js";
|
||||
import {
|
||||
canExecuteMutationTool,
|
||||
isCancellationReply,
|
||||
} from "../router/assistant-confirmation.js";
|
||||
import { buildAssistantInsight } from "../router/assistant-insights.js";
|
||||
import { handlePendingAssistantApproval } from "../router/assistant-chat-response.js";
|
||||
import {
|
||||
readToolError,
|
||||
readToolSuccessMessage,
|
||||
} from "../router/assistant-tool-results.js";
|
||||
import { executeTool } from "../router/assistant-tools.js";
|
||||
|
||||
function createPendingApproval() {
|
||||
return {
|
||||
id: "approval_1",
|
||||
userId: "user_1",
|
||||
conversationId: "conv_1",
|
||||
toolName: "create_project",
|
||||
toolArguments: "{\"name\":\"Apollo\"}",
|
||||
summary: "create project (name=Apollo)",
|
||||
createdAt: Date.now(),
|
||||
expiresAt: Date.now() + 60_000,
|
||||
};
|
||||
}
|
||||
|
||||
function createHandleInput(overrides: Partial<Parameters<typeof handlePendingAssistantApproval>[0]> = {}) {
|
||||
return {
|
||||
db: {} as never,
|
||||
dbUserId: "user_1",
|
||||
toolCtx: {
|
||||
db: {} as never,
|
||||
userId: "user_1",
|
||||
userRole: "USER",
|
||||
permissions: new Set(),
|
||||
session: null,
|
||||
dbUser: null,
|
||||
roleDefaults: null,
|
||||
},
|
||||
conversationId: "conv_1",
|
||||
pendingApproval: createPendingApproval(),
|
||||
lastUserMessage: { role: "user" as const, content: "ja" },
|
||||
messages: [
|
||||
{ role: "assistant" as const, content: "__CAPAKRAKEN_CONFIRM__ create project (name=Apollo). Bitte bestätigen." },
|
||||
{ role: "user" as const, content: "ja" },
|
||||
],
|
||||
collectedActions: [],
|
||||
collectedInsights: [],
|
||||
...overrides,
|
||||
};
|
||||
}
|
||||
|
||||
describe("assistant pending approval handling", () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
vi.mocked(isCancellationReply).mockReturnValue(false);
|
||||
vi.mocked(canExecuteMutationTool).mockReturnValue(true);
|
||||
vi.mocked(readToolError).mockReturnValue(null);
|
||||
vi.mocked(readToolSuccessMessage).mockReturnValue(null);
|
||||
vi.mocked(buildAssistantInsight).mockReturnValue(undefined);
|
||||
});
|
||||
|
||||
it("cancels pending approvals when the user aborts", async () => {
|
||||
vi.mocked(isCancellationReply).mockReturnValue(true);
|
||||
|
||||
const result = await handlePendingAssistantApproval(createHandleInput({
|
||||
lastUserMessage: { role: "user", content: "nein, abbrechen" },
|
||||
}));
|
||||
|
||||
expect(result).toMatchObject({
|
||||
response: {
|
||||
content: "Aktion verworfen: create project (name=Apollo)",
|
||||
approval: {
|
||||
id: "approval_1",
|
||||
status: "cancelled",
|
||||
},
|
||||
},
|
||||
});
|
||||
expect(clearPendingAssistantApproval).toHaveBeenCalledWith({}, "user_1", "conv_1");
|
||||
expect(consumePendingAssistantApproval).not.toHaveBeenCalled();
|
||||
expect(executeTool).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("executes the confirmed mutation and returns its success response", async () => {
|
||||
vi.mocked(consumePendingAssistantApproval).mockResolvedValue({
|
||||
...createPendingApproval(),
|
||||
summary: "create project (name=Apollo, status=DRAFT)",
|
||||
} as never);
|
||||
vi.mocked(executeTool).mockResolvedValue({
|
||||
content: "{\"message\":\"Projekt Apollo angelegt\"}",
|
||||
data: { message: "Projekt Apollo angelegt" },
|
||||
action: { type: "refresh" },
|
||||
} as never);
|
||||
vi.mocked(buildAssistantInsight).mockReturnValue({
|
||||
kind: "holiday_region",
|
||||
title: "Berlin",
|
||||
metrics: [{ label: "Resolved holidays", value: "1" }],
|
||||
});
|
||||
vi.mocked(readToolSuccessMessage).mockReturnValue("Projekt Apollo angelegt");
|
||||
|
||||
const result = await handlePendingAssistantApproval(createHandleInput());
|
||||
|
||||
expect(result).toMatchObject({
|
||||
response: {
|
||||
content: "Ausgeführt: Projekt Apollo angelegt",
|
||||
approval: {
|
||||
id: "approval_1",
|
||||
status: "approved",
|
||||
},
|
||||
actions: [{ type: "refresh" }],
|
||||
insights: [{
|
||||
kind: "holiday_region",
|
||||
title: "Berlin",
|
||||
}],
|
||||
},
|
||||
});
|
||||
expect(executeTool).toHaveBeenCalledWith(
|
||||
"create_project",
|
||||
"{\"name\":\"Apollo\"}",
|
||||
expect.objectContaining({ userId: "user_1" }),
|
||||
);
|
||||
expect(createAuditEntry).toHaveBeenCalledWith(expect.objectContaining({
|
||||
entityName: "create_project",
|
||||
summary: "AI executed previously approved tool: create_project",
|
||||
}));
|
||||
});
|
||||
|
||||
it("does nothing when the user reply is not a valid confirmation", async () => {
|
||||
vi.mocked(canExecuteMutationTool).mockReturnValue(false);
|
||||
|
||||
const result = await handlePendingAssistantApproval(createHandleInput({
|
||||
lastUserMessage: { role: "user", content: "vielleicht" },
|
||||
}));
|
||||
|
||||
expect(result).toBeNull();
|
||||
expect(consumePendingAssistantApproval).not.toHaveBeenCalled();
|
||||
expect(executeTool).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user