refactor(api): extract settings response support

2026-03-31 14:30:57 +02:00
parent 85b4121253
commit 5be1ef15dd
3 changed files with 206 additions and 45 deletions
@@ -5,6 +5,10 @@ import {
  parseAiError,
  sanitizeDiagnosticError,
 } from "../ai-client.js";
+import {
+  RUNTIME_SECRET_FIELDS,
+} from "../lib/system-settings-runtime.js";
+import type { RuntimeSecretField, RuntimeSecretStatus } from "../lib/system-settings-runtime.js";
 import { logger } from "../lib/logger.js";

 /** Fields that must never appear in audit log values */
@@ -75,6 +79,80 @@ export function getDefaultScoreWeights() {
  };
 }

+export function buildSystemSettingsViewModel(input: {
+  settings: {
+    aiProvider?: string | null;
+    azureOpenAiEndpoint?: string | null;
+    azureOpenAiDeployment?: string | null;
+    azureApiVersion?: string | null;
+    aiMaxCompletionTokens?: number | null;
+    aiTemperature?: number | null;
+    aiSummaryPrompt?: string | null;
+    scoreWeights?: unknown;
+    scoreVisibleRoles?: unknown;
+    smtpHost?: string | null;
+    smtpPort?: number | null;
+    smtpUser?: string | null;
+    smtpFrom?: string | null;
+    smtpTls?: boolean | null;
+    anonymizationEnabled?: boolean | null;
+    anonymizationDomain?: string | null;
+    anonymizationMode?: string | null;
+    azureDalleDeployment?: string | null;
+    azureDalleEndpoint?: string | null;
+    geminiModel?: string | null;
+    imageProvider?: string | null;
+    vacationDefaultDays?: number | null;
+    timelineUndoMaxSteps?: number | null;
+  } | null | undefined;
+  runtimeSettings: {
+    azureOpenAiApiKey?: string | null;
+    smtpPassword?: string | null;
+    azureDalleApiKey?: string | null;
+    geminiApiKey?: string | null;
+  } | null | undefined;
+  runtimeSecrets: Record<RuntimeSecretField, RuntimeSecretStatus>;
+  defaultSummaryPrompt: string;
+}) {
+  const defaultWeights = getDefaultScoreWeights();
+  const settings = input.settings;
+
+  return {
+    aiProvider: settings?.aiProvider ?? "openai",
+    azureOpenAiEndpoint: settings?.azureOpenAiEndpoint ?? null,
+    azureOpenAiDeployment: settings?.azureOpenAiDeployment ?? null,
+    azureApiVersion: settings?.azureApiVersion ?? "2025-01-01-preview",
+    aiMaxCompletionTokens: settings?.aiMaxCompletionTokens ?? 300,
+    aiTemperature: settings?.aiTemperature ?? 1,
+    aiSummaryPrompt: settings?.aiSummaryPrompt ?? null,
+    defaultSummaryPrompt: input.defaultSummaryPrompt,
+    hasApiKey: !!input.runtimeSettings?.azureOpenAiApiKey,
+    runtimeSecrets: input.runtimeSecrets,
+    legacyStoredSecretFields: RUNTIME_SECRET_FIELDS.filter(
+      (field) => input.runtimeSecrets[field].hasStoredValue,
+    ),
+    scoreWeights: (settings?.scoreWeights as typeof defaultWeights | null | undefined) ?? defaultWeights,
+    scoreVisibleRoles: (settings?.scoreVisibleRoles as string[] | null | undefined) ?? ["ADMIN", "MANAGER"],
+    smtpHost: settings?.smtpHost ?? null,
+    smtpPort: settings?.smtpPort ?? 587,
+    smtpUser: settings?.smtpUser ?? null,
+    smtpFrom: settings?.smtpFrom ?? null,
+    smtpTls: settings?.smtpTls ?? true,
+    hasSmtpPassword: !!input.runtimeSettings?.smtpPassword,
+    anonymizationEnabled: settings?.anonymizationEnabled ?? false,
+    anonymizationDomain: settings?.anonymizationDomain ?? "superhartmut.de",
+    anonymizationMode: settings?.anonymizationMode ?? "global",
+    azureDalleDeployment: settings?.azureDalleDeployment ?? null,
+    azureDalleEndpoint: settings?.azureDalleEndpoint ?? null,
+    hasDalleApiKey: !!input.runtimeSettings?.azureDalleApiKey,
+    geminiModel: settings?.geminiModel ?? "gemini-2.5-flash-image",
+    hasGeminiApiKey: !!input.runtimeSettings?.geminiApiKey,
+    imageProvider: settings?.imageProvider ?? "dalle",
+    vacationDefaultDays: settings?.vacationDefaultDays ?? 28,
+    timelineUndoMaxSteps: settings?.timelineUndoMaxSteps ?? 50,
+  };
+}
+
 export function buildSettingsUpdatePayload(input: SettingsUpdateInput): {
  data: Record<string, unknown>;
  ignoredSecretFields: string[];