refactor(api): extract settings response support

packages/api/src/router/settings.ts

@@ -5,8 +5,8 @@ import { testSmtpConnection } from "../lib/email.js";
 import { createAuditEntry } from "../lib/audit.js";
 import { getRuntimeSecretStatuses, RUNTIME_SECRET_FIELDS, resolveSystemSettingsRuntime } from "../lib/system-settings-runtime.js";
 import {
+  buildSystemSettingsViewModel,
   buildSettingsUpdatePayload,
-  getDefaultScoreWeights,
   sanitizeSettingsAuditSnapshot,
   settingsUpdateInputSchema,
   testRuntimeAiConnection,
@@ -19,51 +19,12 @@ export const settingsRouter = createTRPCRouter({
     });
     const runtimeSettings = resolveSystemSettingsRuntime(settings);
     const runtimeSecrets = getRuntimeSecretStatuses(settings);
-    const legacyStoredSecretFields = RUNTIME_SECRET_FIELDS.filter(
-      (field) => runtimeSecrets[field].hasStoredValue,
-    );
-
-    const defaultWeights = getDefaultScoreWeights();
-
-    return {
-      aiProvider: settings?.aiProvider ?? "openai",
-      azureOpenAiEndpoint: settings?.azureOpenAiEndpoint ?? null,
-      azureOpenAiDeployment: settings?.azureOpenAiDeployment ?? null,
-      azureApiVersion: settings?.azureApiVersion ?? "2025-01-01-preview",
-      aiMaxCompletionTokens: settings?.aiMaxCompletionTokens ?? 300,
-      aiTemperature: settings?.aiTemperature ?? 1,
-      aiSummaryPrompt: settings?.aiSummaryPrompt ?? null,
-      defaultSummaryPrompt: DEFAULT_SUMMARY_PROMPT,
-      hasApiKey: !!runtimeSettings.azureOpenAiApiKey,
+    return buildSystemSettingsViewModel({
+      settings,
+      runtimeSettings,
       runtimeSecrets,
-      legacyStoredSecretFields,
-      scoreWeights: (settings?.scoreWeights as unknown as typeof defaultWeights) ?? defaultWeights,
-      scoreVisibleRoles: (settings?.scoreVisibleRoles as unknown as string[]) ?? ["ADMIN", "MANAGER"],
-      // SMTP
-      smtpHost: settings?.smtpHost ?? null,
-      smtpPort: settings?.smtpPort ?? 587,
-      smtpUser: settings?.smtpUser ?? null,
-      smtpFrom: settings?.smtpFrom ?? null,
-      smtpTls: settings?.smtpTls ?? true,
-      hasSmtpPassword: !!runtimeSettings.smtpPassword,
-      // Global anonymization
-      anonymizationEnabled: settings?.anonymizationEnabled ?? false,
-      anonymizationDomain: settings?.anonymizationDomain ?? "superhartmut.de",
-      anonymizationMode: settings?.anonymizationMode ?? "global",
-      // DALL-E
-      azureDalleDeployment: settings?.azureDalleDeployment ?? null,
-      azureDalleEndpoint: settings?.azureDalleEndpoint ?? null,
-      hasDalleApiKey: !!runtimeSettings.azureDalleApiKey,
-      // Gemini
-      geminiModel: settings?.geminiModel ?? "gemini-2.5-flash-image",
-      hasGeminiApiKey: !!runtimeSettings.geminiApiKey,
-      // Image provider
-      imageProvider: settings?.imageProvider ?? "dalle",
-      // Vacation defaults
-      vacationDefaultDays: settings?.vacationDefaultDays ?? 28,
-      // Timeline
-      timelineUndoMaxSteps: settings?.timelineUndoMaxSteps ?? 50,
-    };
+      defaultSummaryPrompt: DEFAULT_SUMMARY_PROMPT,
+    });
   }),
 
   updateSystemSettings: adminProcedure