fix(api): harden broadcast transactions and estimate fallbacks

packages/api/src/router/assistant-tools.ts

@@ -622,6 +622,27 @@ function toAssistantEstimateNotFoundError(
   return null;
 }
 
+function toAssistantEstimateReadError(
+  error: unknown,
+  context: "weeklyPhasing" | "commercialTerms",
+): AssistantToolErrorResult | null {
+  const notFound = toAssistantEstimateNotFoundError(error);
+  if (notFound) {
+    return notFound;
+  }
+
+  if (
+    context === "weeklyPhasing"
+    && error instanceof TRPCError
+    && error.code === "PRECONDITION_FAILED"
+    && error.message === "Estimate has no versions"
+  ) {
+    return { error: "Estimate version not found with the given criteria." };
+  }
+
+  return null;
+}
+
 function toAssistantHolidayCalendarNotFoundError(
   error: unknown,
   identifier?: string,
@@ -1708,6 +1729,9 @@ function toAssistantNotificationCreationError(
   }
 
   if (trpcError?.code === "NOT_FOUND") {
+    if (trpcError.message.includes("broadcast")) {
+      return { error: "Broadcast not found with the given criteria." };
+    }
     if (trpcError.message.includes("Sender user not found")) {
       return { error: "Sender user not found with the given criteria." };
     }
@@ -1742,6 +1766,10 @@ function toAssistantNotificationCreationError(
     return { error: "Sender user not found with the given criteria." };
   }
 
+  if (context === "broadcast" && (errorText.includes("notificationbroadcast") || errorText.includes("broadcast"))) {
+    return { error: "Broadcast not found with the given criteria." };
+  }
+
   if (context === "task") {
     return { error: "Task recipient user not found with the given criteria." };
   }
@@ -7400,7 +7428,15 @@ const executors = {
     estimateId: string;
   }, ctx: ToolContext) {
     const caller = createEstimateCaller(createScopedCallerContext(ctx));
-    return caller.getWeeklyPhasing({ estimateId: params.estimateId });
+    try {
+      return await caller.getWeeklyPhasing({ estimateId: params.estimateId });
+    } catch (error) {
+      const mapped = toAssistantEstimateReadError(error, "weeklyPhasing");
+      if (mapped) {
+        return mapped;
+      }
+      throw error;
+    }
   },
 
   async get_estimate_commercial_terms(params: {
@@ -7408,10 +7444,18 @@ const executors = {
     versionId?: string;
   }, ctx: ToolContext) {
     const caller = createEstimateCaller(createScopedCallerContext(ctx));
-    return caller.getCommercialTerms({
-      estimateId: params.estimateId,
-      ...(params.versionId !== undefined ? { versionId: params.versionId } : {}),
-    });
+    try {
+      return await caller.getCommercialTerms({
+        estimateId: params.estimateId,
+        ...(params.versionId !== undefined ? { versionId: params.versionId } : {}),
+      });
+    } catch (error) {
+      const mapped = toAssistantEstimateReadError(error, "commercialTerms");
+      if (mapped) {
+        return mapped;
+      }
+      throw error;
+    }
   },
 
   async update_estimate_commercial_terms(params: {