Hartmut/CapaKraken
1
0
Fork 0
Code Issues 10 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor(api): extract timeline allocation assignment procedures

Browse Source
This commit is contained in:
Hartmut Nörenberg
2026-03-31 18:08:19 +02:00
parent 0b72eef61f
commit 7b4c659922
5 changed files with 202 additions and 193 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/api/src/__tests__/timeline-allocation-assignment-procedure-support.test.ts
+128
View File
@@ -0,0 +1,128 @@
import { beforeEach, describe, expect, it, vi } from "vitest";
vi.mock("@capakraken/application", () => ({
buildSplitAllocationReadModel: vi.fn(),
createAssignment: vi.fn(),
}));
vi.mock("../sse/event-bus.js", () => ({
emitAllocationCreated: vi.fn(),
}));
import {
buildSplitAllocationReadModel,
createAssignment,
} from "@capakraken/application";
import { emitAllocationCreated } from "../sse/event-bus.js";
import {
createTimelineBatchQuickAssignments,
createTimelineQuickAssignment,
} from "../router/timeline-allocation-assignment-procedure-support.js";
const buildSplitAllocationReadModelMock = vi.mocked(buildSplitAllocationReadModel);
const createAssignmentMock = vi.mocked(createAssignment);
const emitAllocationCreatedMock = vi.mocked(emitAllocationCreated);
describe("timeline allocation assignment procedure support", () => {
beforeEach(() => {
vi.clearAllMocks();
});
it("creates a quick assignment and emits the allocation created event", async () => {
const db = {
$transaction: vi.fn(async (callback: (tx: unknown) => unknown) => callback(db)),
} as never;
createAssignmentMock.mockResolvedValueOnce({ id: "assignment_1" } as never);
buildSplitAllocationReadModelMock.mockReturnValueOnce({
allocations: [
{
id: "allocation_1",
projectId: "project_1",
resourceId: "resource_1",
},
],
} as never);
await expect(
createTimelineQuickAssignment(db, {
resourceId: "resource_1",
projectId: "project_1",
startDate: new Date("2026-04-01T00:00:00.000Z"),
endDate: new Date("2026-04-05T00:00:00.000Z"),
hoursPerDay: 8,
role: "Team Member",
status: "PROPOSED",
source: "quickAssign",
}),
).resolves.toEqual({
id: "allocation_1",
projectId: "project_1",
resourceId: "resource_1",
});
expect(createAssignmentMock).toHaveBeenCalledOnce();
expect(emitAllocationCreatedMock).toHaveBeenCalledWith({
id: "allocation_1",
projectId: "project_1",
resourceId: "resource_1",
});
});
it("creates batch quick assignments and emits events for each result", async () => {
const db = {
$transaction: vi.fn(async (callback: (tx: unknown) => unknown) => callback(db)),
} as never;
createAssignmentMock
.mockResolvedValueOnce({
id: "assignment_1",
projectId: "project_1",
resourceId: "resource_1",
} as never)
.mockResolvedValueOnce({
id: "assignment_2",
projectId: "project_2",
resourceId: "resource_2",
} as never);
await expect(
createTimelineBatchQuickAssignments(db, {
assignments: [
{
resourceId: "resource_1",
projectId: "project_1",
startDate: new Date("2026-04-01T00:00:00.000Z"),
endDate: new Date("2026-04-05T00:00:00.000Z"),
hoursPerDay: 8,
role: "Team Member",
status: "PROPOSED",
source: "batchQuickAssign",
},
{
resourceId: "resource_2",
projectId: "project_2",
startDate: new Date("2026-04-06T00:00:00.000Z"),
endDate: new Date("2026-04-10T00:00:00.000Z"),
hoursPerDay: 6,
role: "Lead",
status: "PROPOSED",
source: "batchQuickAssign",
},
],
}),
).resolves.toEqual({ count: 2 });
expect(createAssignmentMock).toHaveBeenCalledTimes(2);
expect(emitAllocationCreatedMock).toHaveBeenNthCalledWith(1, {
id: "assignment_1",
projectId: "project_1",
resourceId: "resource_1",
});
expect(emitAllocationCreatedMock).toHaveBeenNthCalledWith(2, {
id: "assignment_2",
projectId: "project_2",
resourceId: "resource_2",
});
});
});
packages/api/src/__tests__/timeline-allocation-procedure-support.test.ts
+2 -120
View File
@@ -1,12 +1,6 @@
import { beforeEach, describe, expect, it, vi } from "vitest";
vi.mock("@capakraken/application", () => ({
buildSplitAllocationReadModel: vi.fn(),
createAssignment: vi.fn(),
}));
vi.mock("../sse/event-bus.js", () => ({
emitAllocationCreated: vi.fn(),
emitAllocationUpdated: vi.fn(),
}));
@@ -14,24 +8,10 @@ vi.mock("../router/timeline-allocation-shift-support.js", () => ({
applyTimelineBatchAllocationShift: vi.fn(),
}));
import {
buildSplitAllocationReadModel,
createAssignment,
} from "@capakraken/application";
import {
emitAllocationCreated,
emitAllocationUpdated,
} from "../sse/event-bus.js";
import {
createTimelineBatchQuickAssignments,
createTimelineQuickAssignment,
shiftTimelineAllocations,
} from "../router/timeline-allocation-procedure-support.js";
import { emitAllocationUpdated } from "../sse/event-bus.js";
import { shiftTimelineAllocations } from "../router/timeline-allocation-procedure-support.js";
import { applyTimelineBatchAllocationShift } from "../router/timeline-allocation-shift-support.js";
const buildSplitAllocationReadModelMock = vi.mocked(buildSplitAllocationReadModel);
const createAssignmentMock = vi.mocked(createAssignment);
const emitAllocationCreatedMock = vi.mocked(emitAllocationCreated);
const emitAllocationUpdatedMock = vi.mocked(emitAllocationUpdated);
const applyTimelineBatchAllocationShiftMock = vi.mocked(applyTimelineBatchAllocationShift);
@@ -40,104 +20,6 @@ describe("timeline allocation procedure support", () => {
vi.clearAllMocks();
});
it("creates a quick assignment and emits the allocation created event", async () => {
const db = {
$transaction: vi.fn(async (callback: (tx: unknown) => unknown) => callback(db)),
} as never;
createAssignmentMock.mockResolvedValueOnce({ id: "assignment_1" } as never);
buildSplitAllocationReadModelMock.mockReturnValueOnce({
allocations: [
{
id: "allocation_1",
projectId: "project_1",
resourceId: "resource_1",
},
],
} as never);
await expect(
createTimelineQuickAssignment(db, {
resourceId: "resource_1",
projectId: "project_1",
startDate: new Date("2026-04-01T00:00:00.000Z"),
endDate: new Date("2026-04-05T00:00:00.000Z"),
hoursPerDay: 8,
role: "Team Member",
status: "PROPOSED",
source: "quickAssign",
}),
).resolves.toEqual({
id: "allocation_1",
projectId: "project_1",
resourceId: "resource_1",
});
expect(createAssignmentMock).toHaveBeenCalledOnce();
expect(emitAllocationCreatedMock).toHaveBeenCalledWith({
id: "allocation_1",
projectId: "project_1",
resourceId: "resource_1",
});
});
it("creates batch quick assignments and emits events for each result", async () => {
const db = {
$transaction: vi.fn(async (callback: (tx: unknown) => unknown) => callback(db)),
} as never;
createAssignmentMock
.mockResolvedValueOnce({
id: "assignment_1",
projectId: "project_1",
resourceId: "resource_1",
} as never)
.mockResolvedValueOnce({
id: "assignment_2",
projectId: "project_2",
resourceId: "resource_2",
} as never);
await expect(
createTimelineBatchQuickAssignments(db, {
assignments: [
{
resourceId: "resource_1",
projectId: "project_1",
startDate: new Date("2026-04-01T00:00:00.000Z"),
endDate: new Date("2026-04-05T00:00:00.000Z"),
hoursPerDay: 8,
role: "Team Member",
status: "PROPOSED",
source: "batchQuickAssign",
},
{
resourceId: "resource_2",
projectId: "project_2",
startDate: new Date("2026-04-06T00:00:00.000Z"),
endDate: new Date("2026-04-10T00:00:00.000Z"),
hoursPerDay: 6,
role: "Lead",
status: "PROPOSED",
source: "batchQuickAssign",
},
],
}),
).resolves.toEqual({ count: 2 });
expect(createAssignmentMock).toHaveBeenCalledTimes(2);
expect(emitAllocationCreatedMock).toHaveBeenNthCalledWith(1, {
id: "assignment_1",
projectId: "project_1",
resourceId: "resource_1",
});
expect(emitAllocationCreatedMock).toHaveBeenNthCalledWith(2, {
id: "assignment_2",
projectId: "project_2",
resourceId: "resource_2",
});
});
it("applies allocation shifts and emits update events", async () => {
applyTimelineBatchAllocationShiftMock.mockResolvedValueOnce([
{