refactor(api): extract assistant chargeability and country slices

packages/api/src/router/assistant-tools.ts

@@ -6,11 +6,9 @@
 import { Prisma, ImportBatchStatus, StagedRecordStatus, DispoStagedRecordType, VacationType } from "@capakraken/db";
 import {
   CreateAssignmentSchema,
-  CreateCountrySchema,
   type CreateEstimateInput,
   CreateProjectSchema,
   CreateResourceSchema,
-  CreateMetroCitySchema,
   AllocationStatus,
   EstimateExportFormat,
   EstimateStatus,
@@ -19,8 +17,6 @@ import {
   PermissionKey,
   SystemRole,
   type UpdateEstimateDraftInput,
-  UpdateCountrySchema,
-  UpdateMetroCitySchema,
   UpdateProjectSchema,
   UpdateResourceSchema,
 } from "@capakraken/shared";
@@ -87,6 +83,14 @@ import {
   createClientsOrgUnitsExecutors,
   orgUnitMutationToolDefinitions,
 } from "./assistant-tools/clients-org-units.js";
+import {
+  chargeabilityComputationReadToolDefinitions,
+  createChargeabilityComputationExecutors,
+} from "./assistant-tools/chargeability-computation.js";
+import {
+  countryMetroAdminToolDefinitions,
+  createCountryMetroAdminExecutors,
+} from "./assistant-tools/country-metro-admin.js";
 import type { ToolContext, ToolDef, ToolExecutor } from "./assistant-tools/shared.js";
 import { getCommentToolEntityDescription, getCommentToolScopeSentence } from "../lib/comment-entity-registry.js";
 
@@ -1971,60 +1975,7 @@ export const TOOL_DEFINITIONS: ToolDef[] = [
   ...vacationHolidayReadToolDefinitions,
   ...vacationHolidayMutationToolDefinitions,
   ...rolesAnalyticsReadToolDefinitions,
-  {
-    type: "function",
-    function: {
-      name: "get_chargeability_report",
-      description: "Get the detailed chargeability report readmodel for a month range, including group totals and per-resource month series. Requires controller/manager/admin access, viewCosts, and useAssistantAdvancedTools.",
-      parameters: {
-        type: "object",
-        properties: {
-          startMonth: { type: "string", description: "Start month in YYYY-MM format." },
-          endMonth: { type: "string", description: "End month in YYYY-MM format." },
-          orgUnitId: { type: "string", description: "Optional org unit filter." },
-          managementLevelGroupId: { type: "string", description: "Optional management level group filter." },
-          countryId: { type: "string", description: "Optional country filter." },
-          includeProposed: { type: "boolean", description: "Whether proposed bookings should count towards chargeability. Default: false." },
-          resourceQuery: { type: "string", description: "Optional resource filter by name or eid after loading the report." },
-          resourceLimit: { type: "integer", description: "Maximum number of resources returned. Default: 25, max 100." },
-        },
-        required: ["startMonth", "endMonth"],
-      },
-    },
-  },
-  {
-    type: "function",
-    function: {
-      name: "get_resource_computation_graph",
-      description: "Get the resource computation graph with transparent SAH, holiday, absence, allocation, chargeability, and budget derivation factors. Requires controller/manager/admin access, viewCosts, and useAssistantAdvancedTools.",
-      parameters: {
-        type: "object",
-        properties: {
-          resourceId: { type: "string", description: "Resource ID, eid, or display name." },
-          month: { type: "string", description: "Month in YYYY-MM format." },
-          domain: { type: "string", enum: ["INPUT", "SAH", "ALLOCATION", "RULES", "CHARGEABILITY", "BUDGET"], description: "Optional domain filter for graph nodes." },
-          includeLinks: { type: "boolean", description: "Include graph links for the selected nodes. Default: false." },
-        },
-        required: ["resourceId", "month"],
-      },
-    },
-  },
-  {
-    type: "function",
-    function: {
-      name: "get_project_computation_graph",
-      description: "Get the project computation graph with estimate, commercial, effort, experience, spread, and budget derivation factors. Requires controller/manager/admin access, viewCosts, and useAssistantAdvancedTools.",
-      parameters: {
-        type: "object",
-        properties: {
-          projectId: { type: "string", description: "Project ID, short code, or project name." },
-          domain: { type: "string", enum: ["INPUT", "ESTIMATE", "COMMERCIAL", "EXPERIENCE", "EFFORT", "SPREAD", "BUDGET"], description: "Optional domain filter for graph nodes." },
-          includeLinks: { type: "boolean", description: "Include graph links for the selected nodes. Default: false." },
-        },
-        required: ["projectId"],
-      },
-    },
-  },
+  ...chargeabilityComputationReadToolDefinitions,
   {
     type: "function",
     function: {
@@ -2824,99 +2775,7 @@ export const TOOL_DEFINITIONS: ToolDef[] = [
       },
     },
   },
-  {
-    type: "function",
-    function: {
-      name: "create_country",
-      description: "Create a country with daily working hours and optional schedule rules. Admin role required. Always confirm first.",
-      parameters: {
-        type: "object",
-        properties: {
-          code: { type: "string", description: "ISO country code such as DE or ES." },
-          name: { type: "string", description: "Country name." },
-          dailyWorkingHours: { type: "number", description: "Standard daily working hours." },
-          scheduleRules: {
-            type: "object",
-            description: "Optional schedule rule object such as the Spain reduced-hours configuration.",
-          },
-        },
-        required: ["code", "name"],
-      },
-    },
-  },
-  {
-    type: "function",
-    function: {
-      name: "update_country",
-      description: "Update a country including working hours, schedule rules, or active state. Admin role required. Always confirm first.",
-      parameters: {
-        type: "object",
-        properties: {
-          id: { type: "string", description: "Country ID." },
-          data: {
-            type: "object",
-            properties: {
-              code: { type: "string" },
-              name: { type: "string" },
-              dailyWorkingHours: { type: "number" },
-              scheduleRules: { type: ["object", "null"] },
-              isActive: { type: "boolean" },
-            },
-          },
-        },
-        required: ["id", "data"],
-      },
-    },
-  },
-  {
-    type: "function",
-    function: {
-      name: "create_metro_city",
-      description: "Create a metro city for a country. Admin role required. Always confirm first.",
-      parameters: {
-        type: "object",
-        properties: {
-          countryId: { type: "string", description: "Country ID." },
-          name: { type: "string", description: "Metro city name." },
-        },
-        required: ["countryId", "name"],
-      },
-    },
-  },
-  {
-    type: "function",
-    function: {
-      name: "update_metro_city",
-      description: "Rename a metro city. Admin role required. Always confirm first.",
-      parameters: {
-        type: "object",
-        properties: {
-          id: { type: "string", description: "Metro city ID." },
-          data: {
-            type: "object",
-            properties: {
-              name: { type: "string" },
-            },
-          },
-        },
-        required: ["id", "data"],
-      },
-    },
-  },
-  {
-    type: "function",
-    function: {
-      name: "delete_metro_city",
-      description: "Delete a metro city when no resource is assigned to it. Admin role required. Always confirm first.",
-      parameters: {
-        type: "object",
-        properties: {
-          id: { type: "string", description: "Metro city ID." },
-        },
-        required: ["id"],
-      },
-    },
-  },
+  ...countryMetroAdminToolDefinitions,
   {
     type: "function",
     function: {
@@ -4254,76 +4113,14 @@ const executors = {
     toAssistantClientMutationError,
     toAssistantOrgUnitMutationError,
   }),
-
-  async get_chargeability_report(params: {
-    startMonth: string;
-    endMonth: string;
-    orgUnitId?: string;
-    managementLevelGroupId?: string;
-    countryId?: string;
-    includeProposed?: boolean;
-    resourceQuery?: string;
-    resourceLimit?: number;
-  }, ctx: ToolContext) {
-    assertPermission(ctx, PermissionKey.VIEW_COSTS);
-    assertPermission(ctx, PermissionKey.USE_ASSISTANT_ADVANCED_TOOLS);
-
-    const caller = createChargeabilityReportCaller(createScopedCallerContext(ctx));
-    return caller.getDetail({
-      startMonth: params.startMonth,
-      endMonth: params.endMonth,
-      ...(params.orgUnitId ? { orgUnitId: params.orgUnitId } : {}),
-      ...(params.managementLevelGroupId ? { managementLevelGroupId: params.managementLevelGroupId } : {}),
-      ...(params.countryId ? { countryId: params.countryId } : {}),
-      includeProposed: params.includeProposed ?? false,
-      ...(params.resourceQuery ? { resourceQuery: params.resourceQuery } : {}),
-      ...(params.resourceLimit !== undefined ? { resourceLimit: params.resourceLimit } : {}),
-    });
-  },
-
-  async get_resource_computation_graph(params: {
-    resourceId: string;
-    month: string;
-    domain?: string;
-    includeLinks?: boolean;
-  }, ctx: ToolContext) {
-    assertPermission(ctx, PermissionKey.VIEW_COSTS);
-    assertPermission(ctx, PermissionKey.USE_ASSISTANT_ADVANCED_TOOLS);
-
-    const resource = await resolveResourceIdentifier(ctx, params.resourceId);
-    if ("error" in resource) {
-      return resource;
-    }
-
-    const caller = createComputationGraphCaller(createScopedCallerContext(ctx));
-    return caller.getResourceDataDetail({
-      resourceId: resource.id,
-      month: params.month,
-      ...(params.domain ? { domain: params.domain } : {}),
-      ...(params.includeLinks !== undefined ? { includeLinks: params.includeLinks } : {}),
-    });
-  },
-
-  async get_project_computation_graph(params: {
-    projectId: string;
-    domain?: string;
-    includeLinks?: boolean;
-  }, ctx: ToolContext) {
-    assertPermission(ctx, PermissionKey.VIEW_COSTS);
-    assertPermission(ctx, PermissionKey.USE_ASSISTANT_ADVANCED_TOOLS);
-
-    const project = await resolveProjectIdentifier(ctx, params.projectId);
-    if ("error" in project) {
-      return project;
-    }
-
-    const caller = createComputationGraphCaller(createScopedCallerContext(ctx));
-    return caller.getProjectDataDetail({
-      projectId: project.id,
-      ...(params.domain ? { domain: params.domain } : {}),
-      ...(params.includeLinks !== undefined ? { includeLinks: params.includeLinks } : {}),
-    });
-  },
+  ...createChargeabilityComputationExecutors({
+    assertPermission,
+    createChargeabilityReportCaller,
+    createComputationGraphCaller,
+    createScopedCallerContext,
+    resolveResourceIdentifier,
+    resolveProjectIdentifier,
+  }),
 
   async search_estimates(params: {
     projectCode?: string; query?: string; status?: string; limit?: number;
@@ -5698,142 +5495,14 @@ const executors = {
     }
     return formatCountry(country);
   },
-
-  async create_country(params: {
-    code: string;
-    name: string;
-    dailyWorkingHours?: number;
-    scheduleRules?: Prisma.JsonValue | null;
-  }, ctx: ToolContext) {
-    assertAdminRole(ctx);
-    const caller = createCountryCaller(createScopedCallerContext(ctx));
-    let created;
-    try {
-      created = await caller.create(CreateCountrySchema.parse(params));
-    } catch (error) {
-      const mapped = toAssistantCountryMutationError(error);
-      if (mapped) {
-        return mapped;
-      }
-      throw error;
-    }
-
-    return {
-      __action: "invalidate",
-      scope: ["country", "resource", "holidayCalendar", "vacation"],
-      success: true,
-      country: formatCountry(created),
-      message: `Created country: ${created.name}`,
-    };
-  },
-
-  async update_country(params: {
-    id: string;
-    data: {
-      code?: string;
-      name?: string;
-      dailyWorkingHours?: number;
-      scheduleRules?: Prisma.JsonValue | null;
-      isActive?: boolean;
-    };
-  }, ctx: ToolContext) {
-    assertAdminRole(ctx);
-    const caller = createCountryCaller(createScopedCallerContext(ctx));
-    const input = {
-      id: params.id,
-      data: UpdateCountrySchema.parse(params.data),
-    };
-    let updated;
-    try {
-      updated = await caller.update(input);
-    } catch (error) {
-      const mapped = toAssistantCountryMutationError(error);
-      if (mapped) {
-        return mapped;
-      }
-      throw error;
-    }
-
-    return {
-      __action: "invalidate",
-      scope: ["country", "resource", "holidayCalendar", "vacation"],
-      success: true,
-      country: formatCountry(updated),
-      message: `Updated country: ${updated.name}`,
-    };
-  },
-
-  async create_metro_city(params: { countryId: string; name: string }, ctx: ToolContext) {
-    assertAdminRole(ctx);
-    const caller = createCountryCaller(createScopedCallerContext(ctx));
-    let created;
-    try {
-      created = await caller.createCity(CreateMetroCitySchema.parse(params));
-    } catch (error) {
-      const mapped = toAssistantMetroCityMutationError(error);
-      if (mapped) {
-        return mapped;
-      }
-      throw error;
-    }
-
-    return {
-      __action: "invalidate",
-      scope: ["country", "resource", "holidayCalendar", "vacation"],
-      success: true,
-      metroCity: created,
-      message: `Created metro city: ${created.name}`,
-    };
-  },
-
-  async update_metro_city(params: { id: string; data: { name?: string } }, ctx: ToolContext) {
-    assertAdminRole(ctx);
-    const caller = createCountryCaller(createScopedCallerContext(ctx));
-    const input = {
-      id: params.id,
-      data: UpdateMetroCitySchema.parse(params.data),
-    };
-    let updated;
-    try {
-      updated = await caller.updateCity(input);
-    } catch (error) {
-      const mapped = toAssistantMetroCityMutationError(error);
-      if (mapped) {
-        return mapped;
-      }
-      throw error;
-    }
-
-    return {
-      __action: "invalidate",
-      scope: ["country", "resource", "holidayCalendar", "vacation"],
-      success: true,
-      metroCity: updated,
-      message: `Updated metro city: ${updated.name}`,
-    };
-  },
-
-  async delete_metro_city(params: { id: string }, ctx: ToolContext) {
-    assertAdminRole(ctx);
-    const caller = createCountryCaller(createScopedCallerContext(ctx));
-    let deleted;
-    try {
-      deleted = await caller.deleteCity({ id: params.id });
-    } catch (error) {
-      const mapped = toAssistantMetroCityMutationError(error);
-      if (mapped) {
-        return mapped;
-      }
-      throw error;
-    }
-
-    return {
-      __action: "invalidate",
-      scope: ["country", "resource", "holidayCalendar", "vacation"],
-      success: true,
-      message: `Deleted metro city: ${deleted.name ?? params.id}`,
-    };
-  },
+  ...createCountryMetroAdminExecutors({
+    createCountryCaller,
+    createScopedCallerContext,
+    assertAdminRole,
+    formatCountry,
+    toAssistantCountryMutationError,
+    toAssistantMetroCityMutationError,
+  }),
 
   async list_management_levels(_params: Record<string, never>, ctx: ToolContext) {
     const caller = createManagementLevelCaller(createScopedCallerContext(ctx));