test(auth): cover notification and user router audiences

2026-03-30 11:08:14 +02:00
parent c8e82ac221
commit b254ab70ba
3 changed files with 269 additions and 0 deletions
@@ -0,0 +1,130 @@
+import { SystemRole } from "@capakraken/shared";
+import { describe, expect, it, vi } from "vitest";
+import { userRouter } from "../router/user.js";
+import { createCallerFactory } from "../trpc.js";
+
+const createCaller = createCallerFactory(userRouter);
+
+function createContext(
+  db: Record<string, unknown>,
+  options: {
+    role?: SystemRole;
+    session?: boolean;
+  } = {},
+) {
+  const { role = SystemRole.USER, session = true } = options;
+
+  return {
+    session: session
+      ? {
+          user: { email: "user@example.com", name: "User", image: null },
+          expires: "2099-01-01T00:00:00.000Z",
+        }
+      : null,
+    db: db as never,
+    dbUser: session
+      ? {
+          id: role === SystemRole.ADMIN ? "user_admin" : "user_1",
+          systemRole: role,
+          permissionOverrides: null,
+        }
+      : null,
+    roleDefaults: null,
+  };
+}
+
+describe("user router authorization", () => {
+  it("forbids regular users from listing assignable users", async () => {
+    const findMany = vi.fn();
+    const caller = createCaller(createContext({
+      user: {
+        findMany,
+      },
+    }));
+
+    await expect(caller.listAssignable()).rejects.toMatchObject({
+      code: "FORBIDDEN",
+      message: "Manager or Admin role required",
+    });
+
+    expect(findMany).not.toHaveBeenCalled();
+  });
+
+  it("allows managers to list assignable users", async () => {
+    const findMany = vi.fn().mockResolvedValue([
+      { id: "user_1", name: "Alice", email: "alice@example.com" },
+    ]);
+    const caller = createCaller(createContext({
+      user: {
+        findMany,
+      },
+    }, { role: SystemRole.MANAGER }));
+
+    const result = await caller.listAssignable();
+
+    expect(result).toHaveLength(1);
+    expect(findMany).toHaveBeenCalledWith({
+      select: {
+        id: true,
+        name: true,
+        email: true,
+      },
+      orderBy: { name: "asc" },
+    });
+  });
+
+  it("forbids non-admin users from reading effective permissions", async () => {
+    const findUnique = vi.fn();
+    const caller = createCaller(createContext({
+      user: {
+        findUnique,
+      },
+    }, { role: SystemRole.MANAGER }));
+
+    await expect(caller.getEffectivePermissions({ userId: "user_2" })).rejects.toMatchObject({
+      code: "FORBIDDEN",
+      message: "Admin role required",
+    });
+
+    expect(findUnique).not.toHaveBeenCalled();
+  });
+
+  it("forbids non-admin users from disabling TOTP for other users", async () => {
+    const findUnique = vi.fn();
+    const caller = createCaller(createContext({
+      user: {
+        findUnique,
+      },
+    }, { role: SystemRole.MANAGER }));
+
+    await expect(caller.disableTotp({ userId: "user_2" })).rejects.toMatchObject({
+      code: "FORBIDDEN",
+      message: "Admin role required",
+    });
+
+    expect(findUnique).not.toHaveBeenCalled();
+  });
+
+  it("keeps TOTP verification public for the login flow", async () => {
+    const findUniqueOrThrow = vi.fn().mockResolvedValue({
+      id: "user_1",
+      totpEnabled: false,
+      totpSecret: null,
+    });
+    const caller = createCaller(createContext({
+      user: {
+        findUniqueOrThrow,
+      },
+    }, { session: false }));
+
+    await expect(caller.verifyTotp({ userId: "user_1", token: "123456" })).rejects.toMatchObject({
+      code: "BAD_REQUEST",
+      message: "TOTP is not enabled for this user.",
+    });
+
+    expect(findUniqueOrThrow).toHaveBeenCalledWith({
+      where: { id: "user_1" },
+      select: { id: true, totpSecret: true, totpEnabled: true },
+    });
+  });
+});