From be6be64e3da09283ae329ee45d0e8c981375e61b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hartmut=20N=C3=B6renberg?= Date: Mon, 30 Mar 2026 14:37:10 +0200 Subject: [PATCH] test(web): cover timeline and estimate fallback flows --- apps/web/e2e/estimates.spec.ts | 80 +++++++++++++++++++++++++--------- apps/web/e2e/timeline.spec.ts | 17 ++++++++ 2 files changed, 76 insertions(+), 21 deletions(-) diff --git a/apps/web/e2e/estimates.spec.ts b/apps/web/e2e/estimates.spec.ts index 227dcb7..32eb609 100644 --- a/apps/web/e2e/estimates.spec.ts +++ b/apps/web/e2e/estimates.spec.ts @@ -1,23 +1,31 @@ -import { expect, test } from "@playwright/test"; +import { expect, test, type Page } from "@playwright/test"; + +async function signIn(page: Page, email: string, password: string) { + await page.goto("/auth/signin"); + await page.fill('input[type="email"]', email); + await page.fill('input[type="password"]', password); + await page.click('button[type="submit"]'); + await expect(page).toHaveURL(/\/(dashboard|resources)/); +} test.describe("Estimates", () => { test.beforeEach(async ({ page }) => { - await page.goto("/auth/signin"); - await page.fill('input[type="email"]', "admin@capakraken.dev"); - await page.fill('input[type="password"]', "admin123"); - await page.click('button[type="submit"]'); - await expect(page).toHaveURL(/\/(dashboard|resources)/); + await signIn(page, "admin@capakraken.dev", "admin123"); await page.goto("/estimates"); }); test("estimate list loads", async ({ page }) => { await page.waitForLoadState("networkidle"); await expect( - page.locator("h1").filter({ hasText: /Estimates/i }), + page.getByRole("heading", { name: /estimate workspace/i }), ).toBeVisible({ timeout: 10000 }); - // Should show either a table/list or an empty state await expect( - page.locator("table").or(page.locator("text=No estimates")).or(page.locator("[data-estimate-id]")), + page.getByPlaceholder("Search by estimate or opportunity"), + ).toBeVisible({ timeout: 10000 }); + await expect( + page.locator("text=No estimates yet").or( + page.locator("text=Select an estimate to inspect the current version, demand lines, and summary metrics."), + ), ).toBeVisible({ timeout: 10000 }); }); @@ -26,10 +34,9 @@ test.describe("Estimates", () => { const newBtn = page.locator("button", { hasText: /New Estimate/i }); await expect(newBtn).toBeVisible({ timeout: 10000 }); await newBtn.click(); - // Wizard step 1 should appear: "Setup" - await expect( - page.locator("text=Setup").or(page.locator("text=Estimate Name")), - ).toBeVisible({ timeout: 5000 }); + await expect(page.getByRole("button", { name: /Step 1 Setup/i })).toBeVisible({ + timeout: 5000, + }); }); test("estimate wizard navigates through steps", async ({ page }) => { @@ -37,7 +44,7 @@ test.describe("Estimates", () => { await page.locator("button", { hasText: /New Estimate/i }).click(); // Step 1: Setup — fill a name - await expect(page.locator("text=Setup")).toBeVisible({ timeout: 5000 }); + await expect(page.getByRole("button", { name: /Step 1 Setup/i })).toBeVisible({ timeout: 5000 }); const nameInput = page.locator('input[placeholder*="name"]').or(page.locator('input[name="name"]')).first(); if ((await nameInput.count()) > 0) { await nameInput.fill(`E2E Estimate ${Date.now()}`); @@ -48,10 +55,9 @@ test.describe("Estimates", () => { if ((await nextBtn.count()) > 0) { await nextBtn.click(); await page.waitForTimeout(500); - // Step 2: Assumptions - await expect( - page.locator("text=Assumptions").or(page.locator("text=Scope")), - ).toBeVisible({ timeout: 5000 }); + await expect(page.getByRole("button", { name: /Step 2 Assumptions/i })).toBeVisible({ + timeout: 5000, + }); } // Close the wizard without completing @@ -68,11 +74,43 @@ test.describe("Estimates", () => { await page.locator("button", { hasText: /New Estimate/i }).click(); // The wizard header should show step labels - const steps = ["Setup", "Assumptions", "Scope", "Staffing", "Review"]; - for (const step of steps) { - await expect(page.locator(`text=${step}`).first()).toBeVisible({ timeout: 5000 }); + const stepButtons = [ + /Step 1 Setup/i, + /Step 2 Assumptions/i, + /Step 3 Scope/i, + /Step 4 Staffing/i, + /Step 5 Review/i, + ]; + for (const stepButton of stepButtons) { + await expect(page.getByRole("button", { name: stepButton })).toBeVisible({ timeout: 5000 }); } await page.keyboard.press("Escape"); }); + + test("shows the empty-state fallback when no estimates exist", async ({ page }) => { + await page.waitForLoadState("networkidle"); + await expect( + page.locator("text=No estimates yet"), + ).toBeVisible({ timeout: 10000 }); + }); + + test("shows an estimate-not-found fallback for unknown workspaces", async ({ page }) => { + await page.goto("/estimates/missing-estimate"); + await page.waitForLoadState("networkidle"); + await expect(page.getByText(/Estimate not found/i)).toBeVisible({ timeout: 10000 }); + }); + + test("shows the restricted workspace fallback for viewers", async ({ browser }) => { + const page = await browser.newPage(); + await signIn(page, "viewer@capakraken.dev", "viewer123"); + await page.goto("/estimates/missing-estimate"); + await page.waitForLoadState("networkidle"); + + await expect( + page.locator("text=Your role can access the estimate list, but not the detailed financial workspace."), + ).toBeVisible({ timeout: 10000 }); + + await page.close(); + }); }); diff --git a/apps/web/e2e/timeline.spec.ts b/apps/web/e2e/timeline.spec.ts index f317f29..3341b5e 100644 --- a/apps/web/e2e/timeline.spec.ts +++ b/apps/web/e2e/timeline.spec.ts @@ -46,6 +46,23 @@ test.describe("Timeline", () => { await todayBtn.click(); }); + test("keeps timeline data populated after navigating from allocations", async ({ page }) => { + await page.goto("/allocations"); + await expect( + page.locator("h1").filter({ hasText: /Allocations|Planning/i }), + ).toBeVisible({ timeout: 10000 }); + + await page.locator('nav a >> text="Timeline"').first().click(); + await expect(page).toHaveURL(/\/timeline/); + await expect( + page.locator(".app-toolbar").getByText(/[1-9]\d* resources · [1-9]\d* allocations/), + ).toBeVisible({ timeout: 10000 }); + await expect(page.getByTestId("timeline-resource-row-canvas").first()).toBeVisible({ + timeout: 10000, + }); + await expect(page.locator("text=No allocations in this time range")).not.toBeVisible(); + }); + test("filter panel opens and closes", async ({ page }) => { await page.locator("button", { hasText: "Filter" }).click(); await expect(page.getByRole("heading", { name: "Filters" })).toBeVisible();