fix(vacation): scope preview requests to owned resources

This commit is contained in:
2026-03-30 12:07:26 +02:00
parent 6a6e98b5f7
commit c7434c968e
4 changed files with 180 additions and 0 deletions
+13
View File
@@ -179,6 +179,19 @@ Reasoning:
- cross-resource balance reads and year summaries are operational planning and approval workflows, so they stay with controller/manager/admin audiences rather than broad authenticated access - cross-resource balance reads and year summaries are operational planning and approval workflows, so they stay with controller/manager/admin audiences rather than broad authenticated access
- bulk entitlement changes affect many users at once and should remain restricted to the smallest administrative audience - bulk entitlement changes affect many users at once and should remain restricted to the smallest administrative audience
### `packages/api/src/router/vacation.ts`
- `previewRequest`, `list`, `getById`, `getForResource`, `getTeamOverlap`, `getTeamOverlapDetail`, `cancel`: `self-service` for the caller's own resource, with elevated cross-resource reads for manager and admin roles
- `create`: `self-service` for the caller's own resource, with elevated creation for manager and admin roles
- `approve`, `reject`, `getPendingApprovals`, `updateStatus` approval paths: `manager-write`
- `batchCreatePublicHolidays`: `admin-only`
Reasoning:
- the employee-facing vacation flows are valid self-service features, but they must not reveal holiday context, overlap data, or request details for arbitrary resources
- manager and admin roles already handle approval and operational cross-resource workflows, so they retain broader access where the route logic explicitly allows it
- bulk public-holiday generation changes organization-wide absence data and therefore belongs to the smallest administrative audience
### `packages/api/src/router/notification.ts` ### `packages/api/src/router/notification.ts`
- `list`, `unreadCount`, `markRead`, task detail/status routes, reminder routes, and `delete`: `self-service` - `list`, `unreadCount`, `markRead`, task detail/status routes, reminder routes, and `delete`: `self-service`
@@ -0,0 +1,164 @@
import { SystemRole } from "@capakraken/shared";
import { VacationType } from "@capakraken/db";
import { describe, expect, it, vi } from "vitest";
import { vacationRouter } from "../router/vacation.js";
import { createCallerFactory } from "../trpc.js";
const createCaller = createCallerFactory(vacationRouter);
function createContext(
db: Record<string, unknown>,
options: {
role?: SystemRole;
session?: boolean;
} = {},
) {
const { role = SystemRole.USER, session = true } = options;
return {
session: session
? {
user: { email: "user@example.com", name: "User", image: null },
expires: "2099-01-01T00:00:00.000Z",
}
: null,
db: db as never,
dbUser: session
? {
id: role === SystemRole.ADMIN ? "user_admin" : role === SystemRole.MANAGER ? "user_mgr" : "user_1",
systemRole: role,
permissionOverrides: null,
}
: null,
};
}
function previewInput(resourceId: string) {
return {
resourceId,
type: VacationType.ANNUAL,
startDate: new Date("2026-08-10T00:00:00.000Z"),
endDate: new Date("2026-08-12T00:00:00.000Z"),
};
}
describe("vacation router authorization", () => {
it("requires authentication for preview requests", async () => {
const resourceFindFirst = vi.fn();
const resourceFindUnique = vi.fn();
const caller = createCaller(createContext({
resource: {
findFirst: resourceFindFirst,
findUnique: resourceFindUnique,
},
vacation: {
findMany: vi.fn(),
},
}, { session: false }));
await expect(caller.previewRequest(previewInput("res_1"))).rejects.toMatchObject({
code: "UNAUTHORIZED",
message: "Authentication required",
});
expect(resourceFindFirst).not.toHaveBeenCalled();
expect(resourceFindUnique).not.toHaveBeenCalled();
});
it("forbids regular users from previewing another resource's request", async () => {
const resourceFindUnique = vi.fn();
const vacationFindMany = vi.fn();
const caller = createCaller(createContext({
resource: {
findFirst: vi.fn().mockResolvedValue({ id: "res_own" }),
findUnique: resourceFindUnique,
},
vacation: {
findMany: vacationFindMany,
},
}));
await expect(caller.previewRequest(previewInput("res_other"))).rejects.toMatchObject({
code: "FORBIDDEN",
message: "You can only view vacation data for your own resource",
});
expect(resourceFindUnique).not.toHaveBeenCalled();
expect(vacationFindMany).not.toHaveBeenCalled();
});
it("allows regular users to preview their own requests", async () => {
const resourceFindUnique = vi.fn().mockResolvedValue({
federalState: "BY",
countryId: "country_de",
metroCityId: null,
country: { code: "DE", name: "Germany" },
metroCity: null,
});
const vacationFindMany = vi.fn().mockResolvedValue([]);
const caller = createCaller(createContext({
resource: {
findFirst: vi.fn().mockResolvedValue({ id: "res_own" }),
findUnique: resourceFindUnique,
},
holidayCalendar: {
findMany: vi.fn().mockResolvedValue([]),
},
vacation: {
findMany: vacationFindMany,
},
}));
const result = await caller.previewRequest(previewInput("res_own"));
expect(result.requestedDays).toBe(3);
expect(resourceFindUnique).toHaveBeenCalledWith({
where: { id: "res_own" },
select: {
federalState: true,
countryId: true,
metroCityId: true,
country: { select: { code: true, name: true } },
metroCity: { select: { name: true } },
},
});
});
it("allows managers to preview requests for other resources", async () => {
const resourceFindFirst = vi.fn();
const resourceFindUnique = vi.fn().mockResolvedValue({
federalState: "BY",
countryId: "country_de",
metroCityId: null,
country: { code: "DE", name: "Germany" },
metroCity: null,
});
const caller = createCaller(createContext({
resource: {
findFirst: resourceFindFirst,
findUnique: resourceFindUnique,
},
holidayCalendar: {
findMany: vi.fn().mockResolvedValue([]),
},
vacation: {
findMany: vi.fn().mockResolvedValue([]),
},
}, { role: SystemRole.MANAGER }));
const result = await caller.previewRequest(previewInput("res_other"));
expect(result.requestedDays).toBe(3);
expect(resourceFindFirst).not.toHaveBeenCalled();
expect(resourceFindUnique).toHaveBeenCalledWith({
where: { id: "res_other" },
select: {
federalState: true,
countryId: true,
metroCityId: true,
country: { select: { code: true, name: true } },
metroCity: { select: { name: true } },
},
});
});
});
@@ -128,6 +128,7 @@ function createVacationDb(overrides: Record<string, unknown> = {}) {
findMany: vi.fn().mockResolvedValue([{ id: "mgr_1" }, { id: "admin_1" }]), findMany: vi.fn().mockResolvedValue([{ id: "mgr_1" }, { id: "admin_1" }]),
}, },
resource: { resource: {
findFirst: vi.fn().mockResolvedValue({ id: "res_1" }),
findUnique: vi.fn().mockImplementation(async (args?: { select?: Record<string, unknown> }) => { findUnique: vi.fn().mockImplementation(async (args?: { select?: Record<string, unknown> }) => {
const select = args?.select ?? {}; const select = args?.select ?? {};
return { return {
+2
View File
@@ -266,6 +266,8 @@ export const vacationRouter = createTRPCRouter({
previewRequest: protectedProcedure previewRequest: protectedProcedure
.input(PreviewVacationRequestSchema) .input(PreviewVacationRequestSchema)
.query(async ({ ctx, input }) => { .query(async ({ ctx, input }) => {
await assertCanReadVacationResource(ctx, input.resourceId);
const holidayContext = await loadResourceHolidayContext( const holidayContext = await loadResourceHolidayContext(
ctx.db, ctx.db,
input.resourceId, input.resourceId,