feat(import): harden workbook parser boundaries

2026-03-31 22:48:30 +02:00
parent 3e8b1702bc
commit db50e2e555
20 changed files with 936 additions and 174 deletions
@@ -0,0 +1,106 @@
+import { describe, expect, it } from "vitest";
+import { matchRoleName, parseSkillMatrixWorkbook } from "./skillMatrixParser.js";
+
+async function createWorkbookBuffer(
+  sheets: Array<{ name: string; rows: unknown[][] }>,
+): Promise<ArrayBuffer> {
+  const ExcelJS = await import("exceljs");
+  const workbook = new ExcelJS.Workbook();
+
+  for (const sheet of sheets) {
+    const worksheet = workbook.addWorksheet(sheet.name);
+    for (const row of sheet.rows) {
+      worksheet.addRow(row);
+    }
+  }
+
+  const buffer = await workbook.xlsx.writeBuffer();
+  const bytes = buffer instanceof Uint8Array ? buffer : new Uint8Array(buffer);
+  return bytes.buffer.slice(bytes.byteOffset, bytes.byteOffset + bytes.byteLength);
+}
+
+describe("skill matrix parser", () => {
+  it("extracts employee info and merges skills by highest proficiency", async () => {
+    const workbook = await createWorkbookBuffer([
+      {
+        name: "Employee Information",
+        rows: [
+          ["item", "property"],
+          ["Full Name", "Alex Artist"],
+          ["Area of Expertise", "Compositing"],
+          ["Years of Experience", "7.4"],
+          ["Portfolio URL", "https://portfolio.example/alex"],
+        ],
+      },
+      {
+        name: "Software Skills",
+        rows: [
+          ["category", "item", "property", "main skillset"],
+          ["Software", "Nuke", "2", "1"],
+          ["Software", "Photoshop", "0", ""],
+        ],
+      },
+      {
+        name: "Technical Skillset",
+        rows: [
+          ["category", "item", "property", "main skillset"],
+          ["Pipeline", "Nuke", "4", ""],
+          ["Pipeline", "Python", "3", "2"],
+        ],
+      },
+    ]);
+
+    await expect(parseSkillMatrixWorkbook(workbook)).resolves.toEqual({
+      employeeInfo: {
+        displayName: "Alex Artist",
+        areaOfExpertise: "Compositing",
+        yearsOfExperience: 7,
+        portfolioUrl: "https://portfolio.example/alex",
+      },
+      skills: expect.arrayContaining([
+        {
+          skill: "Nuke",
+          category: "Pipeline",
+          proficiency: 5,
+        },
+        {
+          skill: "Python",
+          category: "Pipeline",
+          proficiency: 4,
+          isMainSkill: true,
+        },
+      ]),
+    });
+  });
+
+  it("rejects duplicate headers in skill sheets", async () => {
+    const workbook = await createWorkbookBuffer([
+      {
+        name: "Employee Information",
+        rows: [
+          ["item", "property"],
+          ["Full Name", "Alex Artist"],
+        ],
+      },
+      {
+        name: "Software Skills",
+        rows: [
+          ["item", "item", "property"],
+          ["Nuke", "Duplicate", "2"],
+        ],
+      },
+      {
+        name: "Technical Skillset",
+        rows: [["category", "item", "property"]],
+      },
+    ]);
+
+    await expect(parseSkillMatrixWorkbook(workbook)).rejects.toThrow('duplicate header "item"');
+  });
+
+  it("matches role names by exact and partial matches", () => {
+    expect(matchRoleName("Compositing", ["Producer", "Compositing"])).toBe("Compositing");
+    expect(matchRoleName("Senior Producer", ["Producer", "Lighting"])).toBe("Producer");
+    expect(matchRoleName("Rigging", ["Producer", "Lighting"])).toBeNull();
+  });
+});