refactor(api): extract report template procedures

2026-03-31 19:35:01 +02:00
parent f7fe5c6d19
commit ded8f1a163
3 changed files with 463 additions and 178 deletions
@@ -0,0 +1,258 @@
+import { describe, expect, it, vi } from "vitest";
+import {
+  DeleteReportTemplateInputSchema,
+  deleteReportTemplate,
+  listReportTemplates,
+  SaveReportTemplateInputSchema,
+  saveReportTemplate,
+} from "../router/report-template-procedure-support.js";
+
+function createContext(reportTemplate: Record<string, unknown>) {
+  return {
+    db: {
+      reportTemplate,
+    },
+    dbUser: {
+      id: "user_controller",
+      systemRole: "CONTROLLER",
+      permissionOverrides: null,
+    },
+  } as const;
+}
+
+describe("report template procedure support", () => {
+  it("lists shared and owned templates with parsed config and ownership flags", async () => {
+    const updatedAt = new Date("2026-03-31T10:00:00.000Z");
+    const ctx = createContext({
+      findMany: vi.fn().mockResolvedValue([
+        {
+          id: "tpl_1",
+          name: "Owned resource month",
+          description: "Monthly default",
+          entity: "RESOURCE_MONTH",
+          config: {
+            entity: "resource_month",
+            columns: ["displayName", "monthlySahHours"],
+            filters: [],
+            periodMonth: "2026-03",
+          },
+          isShared: false,
+          ownerId: "user_controller",
+          updatedAt,
+        },
+        {
+          id: "tpl_2",
+          name: "Shared project",
+          description: null,
+          entity: "PROJECT",
+          config: {
+            entity: "project",
+            columns: ["name"],
+            filters: [],
+          },
+          isShared: true,
+          ownerId: "user_other",
+          updatedAt,
+        },
+      ]),
+    });
+
+    const result = await listReportTemplates(ctx);
+
+    expect(ctx.db.reportTemplate.findMany).toHaveBeenCalledWith({
+      where: {
+        OR: [
+          { ownerId: "user_controller" },
+          { isShared: true },
+        ],
+      },
+      orderBy: [{ name: "asc" }],
+      select: {
+        id: true,
+        name: true,
+        description: true,
+        entity: true,
+        config: true,
+        isShared: true,
+        ownerId: true,
+        updatedAt: true,
+      },
+    });
+    expect(result).toEqual([
+      {
+        id: "tpl_1",
+        name: "Owned resource month",
+        description: "Monthly default",
+        entity: "resource_month",
+        config: {
+          entity: "resource_month",
+          columns: ["displayName", "monthlySahHours"],
+          filters: [],
+          periodMonth: "2026-03",
+          sortDir: "asc",
+        },
+        isShared: false,
+        isOwner: true,
+        updatedAt,
+      },
+      {
+        id: "tpl_2",
+        name: "Shared project",
+        description: null,
+        entity: "project",
+        config: {
+          entity: "project",
+          columns: ["name"],
+          filters: [],
+          sortDir: "asc",
+        },
+        isShared: true,
+        isOwner: false,
+        updatedAt,
+      },
+    ]);
+  });
+
+  it("upserts new templates under the current owner with converted entity values", async () => {
+    const upsert = vi.fn().mockResolvedValue({
+      id: "tpl_new",
+      updatedAt: new Date("2026-03-31T11:00:00.000Z"),
+    });
+    const ctx = createContext({
+      upsert,
+    });
+    const input = SaveReportTemplateInputSchema.parse({
+      name: "Monthly default",
+      description: "Team-wide default",
+      isShared: true,
+      config: {
+        entity: "resource_month",
+        columns: ["displayName", "monthlyTargetHours"],
+        filters: [],
+        periodMonth: "2026-03",
+      },
+    });
+
+    const result = await saveReportTemplate(ctx, input);
+
+    expect(result).toEqual({
+      id: "tpl_new",
+      updatedAt: new Date("2026-03-31T11:00:00.000Z"),
+    });
+    expect(upsert).toHaveBeenCalledWith({
+      where: {
+        ownerId_name: {
+          ownerId: "user_controller",
+          name: "Monthly default",
+        },
+      },
+      update: {
+        description: "Team-wide default",
+        entity: "RESOURCE_MONTH",
+        config: {
+          entity: "resource_month",
+          columns: ["displayName", "monthlyTargetHours"],
+          filters: [],
+          periodMonth: "2026-03",
+          sortDir: "asc",
+        },
+        isShared: true,
+      },
+      create: {
+        ownerId: "user_controller",
+        name: "Monthly default",
+        description: "Team-wide default",
+        entity: "RESOURCE_MONTH",
+        config: {
+          entity: "resource_month",
+          columns: ["displayName", "monthlyTargetHours"],
+          filters: [],
+          periodMonth: "2026-03",
+          sortDir: "asc",
+        },
+        isShared: true,
+      },
+      select: { id: true, updatedAt: true },
+    });
+  });
+
+  it("updates owned templates and rejects updates for foreign templates", async () => {
+    const findUnique = vi.fn()
+      .mockResolvedValueOnce({ ownerId: "user_controller" })
+      .mockResolvedValueOnce({ ownerId: "user_other" });
+    const update = vi.fn().mockResolvedValue({
+      id: "tpl_1",
+      updatedAt: new Date("2026-03-31T12:00:00.000Z"),
+    });
+    const ctx = createContext({
+      findUnique,
+      update,
+    });
+
+    const ownedResult = await saveReportTemplate(ctx, SaveReportTemplateInputSchema.parse({
+      id: "tpl_1",
+      name: "Owned template",
+      description: "Updated",
+      config: {
+        entity: "project",
+        columns: ["name"],
+        filters: [],
+      },
+    }));
+
+    expect(ownedResult).toEqual({
+      id: "tpl_1",
+      updatedAt: new Date("2026-03-31T12:00:00.000Z"),
+    });
+    expect(update).toHaveBeenCalledWith({
+      where: { id: "tpl_1" },
+      data: {
+        name: "Owned template",
+        description: "Updated",
+        entity: "PROJECT",
+        config: {
+          entity: "project",
+          columns: ["name"],
+          filters: [],
+          sortDir: "asc",
+        },
+        isShared: false,
+      },
+      select: { id: true, updatedAt: true },
+    });
+
+    await expect(saveReportTemplate(ctx, SaveReportTemplateInputSchema.parse({
+      id: "tpl_2",
+      name: "Foreign template",
+      config: {
+        entity: "resource",
+        columns: ["displayName"],
+        filters: [],
+      },
+    }))).rejects.toMatchObject({
+      code: "FORBIDDEN",
+      message: "Template cannot be updated",
+    });
+  });
+
+  it("deletes only owned templates", async () => {
+    const findUnique = vi.fn()
+      .mockResolvedValueOnce({ ownerId: "user_controller" })
+      .mockResolvedValueOnce({ ownerId: "user_other" });
+    const del = vi.fn().mockResolvedValue(undefined);
+    const ctx = createContext({
+      findUnique,
+      delete: del,
+    });
+
+    const result = await deleteReportTemplate(ctx, DeleteReportTemplateInputSchema.parse({ id: "tpl_1" }));
+
+    expect(result).toEqual({ ok: true });
+    expect(del).toHaveBeenCalledWith({ where: { id: "tpl_1" } });
+
+    await expect(deleteReportTemplate(ctx, DeleteReportTemplateInputSchema.parse({ id: "tpl_2" }))).rejects.toMatchObject({
+      code: "FORBIDDEN",
+      message: "Template cannot be deleted",
+    });
+  });
+});