Commit Graph

6 Commits

Author SHA1 Message Date
Hartmut d9a7ec0338 test(application): bump exceljs row/column-limit test timeouts to 60s
CI / Architecture Guardrails (push) Successful in 2m39s
CI / Lint (push) Successful in 7m11s
CI / Assistant Split Regression (push) Successful in 8m57s
CI / Typecheck (push) Successful in 12m1s
CI / Unit Tests (push) Successful in 10m18s
CI / Build (push) Successful in 9m29s
CI / E2E Tests (push) Successful in 5m52s
CI / Fresh-Linux Docker Deploy (push) Successful in 6m54s
CI / Release Images (push) Successful in 4m39s
Nightly Security / Dependency Audit (push) Failing after 1m44s
Run #115 on main timed out after 30s on the Gitea runner under
concurrent-job load (writing 10001 rows via ExcelJS addRow + writeFile
is CPU-bound and CI contention pushed it past the previous threshold).
Locally these tests complete in ~1s, so doubling the budget removes
the flake without masking real regressions.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-18 14:09:10 +02:00
Hartmut c4b01c1bfc security: workbook path allowlist + stronger image polyglot validation (#54)
- dispo workbook imports are pinned to DISPO_IMPORT_DIR (default ./imports):
  tRPC input rejects absolute paths and .. segments, runtime reader
  re-validates containment via path.relative. Closes a path-traversal
  class that reached ExcelJS CVEs through admin/compromised tokens.
- image validator now checks the full 8-byte PNG magic, enforces PNG IEND
  and JPEG EOI trailers, scans the decoded buffer for markup polyglot
  markers (<script, <svg, <iframe, javascript:, onerror=, ...), and
  explicitly rejects SVG. Provider-generated covers (DALL-E, Gemini) run
  through the same validator before persistence — an untrusted upstream
  cannot smuggle a stored-XSS payload past us.
- added image-validation.test.ts and tightened documentation.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-17 15:26:29 +02:00
Hartmut c7d36ecbbd test(application): extend ExcelJS read-workbook timeouts to 30s
CI / Assistant Split Regression (push) Successful in 11m15s
CI / Lint (push) Successful in 9m38s
CI / Typecheck (push) Successful in 11m19s
CI / Unit Tests (push) Successful in 9m48s
CI / Build (push) Successful in 8m19s
CI / E2E Tests (push) Successful in 5m54s
CI / Fresh-Linux Docker Deploy (push) Failing after 6m45s
CI / Release Images (push) Has been skipped
CI / Architecture Guardrails (push) Successful in 9m17s
The 'rejects worksheets that exceed the row limit' test took 6599ms on
the QNAP act_runner, overflowing the default 5000ms vitest timeout.
Writing and parsing MAX_DISPO_WORKBOOK_ROWS+1 rows via ExcelJS is slow
on constrained hardware. Extend timeout for all three writeWorkbook-
dependent tests (row limit, column limit) to 30s, matching the fix
already applied to excel.test.ts and workbook-export.test.ts.
2026-04-13 05:24:07 +02:00
Hartmut 23e68bc137 test(application): skip dispo-import suites when NDA sample xlsx fixtures absent
CI / Typecheck (push) Failing after 3m15s
CI / Architecture Guardrails (push) Successful in 3m52s
CI / Build (push) Has been skipped
CI / E2E Tests (push) Has been skipped
CI / Assistant Split Regression (push) Successful in 4m23s
CI / Lint (push) Successful in 4m53s
CI / Unit Tests (push) Has been cancelled
CI / Release Images (push) Has been cancelled
CI / Fresh-Linux Docker Deploy (push) Has been skipped
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-12 20:11:30 +02:00
Hartmut db50e2e555 feat(import): harden workbook parser boundaries 2026-03-31 22:48:30 +02:00
Hartmut f6daf21983 feat(import): harden untrusted spreadsheet boundaries 2026-03-30 08:02:52 +02:00