Files
Nexus/packages/api/src/__tests__/assistant-tools-comments-create-errors.test.ts
T
Hartmut 4a5edeef3e
CI / Unit Tests (pull_request) Successful in 5m46s
CI / Lint (pull_request) Failing after 3m49s
CI / E2E Tests (pull_request) Has been skipped
CI / Fresh-Linux Docker Deploy (pull_request) Has been skipped
CI / Assistant Split Regression (pull_request) Failing after 35s
CI / Architecture Guardrails (pull_request) Failing after 2m14s
CI / Typecheck (pull_request) Successful in 4m22s
CI / Build (pull_request) Has been skipped
CI / Release Images (pull_request) Has been skipped
rename(phase 1): CapaKraken → Nexus across code, UI, docs, CI
- @capakraken/* → @nexus/* across 12 packages (root + 11 workspaces),
  1551 import lines migrated via codemod
- User-visible brand strings renamed (emails, page titles, PWA
  manifest, mobile header, MFA backup-codes header, tooltips, signin
  page, invite page, weekly digest, install prompt)
- TOTP issuer "CapaKraken" → "Nexus" (existing secrets still valid;
  re-enrollment relabels them in users' authenticator apps)
- Function rename: assertCapaKrakenDbTarget → assertNexusDbTarget
- LocalStorage migration shim in apps/web/src/app/layout.tsx copies
  capakraken_* → nexus_* on first load (guarded by nexus_migrated_v1
  sentinel; runs once per browser, then never again)
- Service-worker cache name capakraken-v2 → nexus-v2 with one-time
  caches.delete('capakraken-v2') from the same shim
- Email-domain fixtures @capakraken.{dev,app} → @nexus.{dev,app} in
  seed data, e2e specs, SMTP default fallback
- Dockerfile.dev / Dockerfile.prod / all .github/workflows/*.yml
  pnpm --filter @capakraken/* → @nexus/*
- README, CLAUDE.md, LEARNINGS.md, all docs/*.md, .env.example,
  tooling/deploy/.env.production.example brand sweep

Phase 1 deliberately leaves untouched (handled in Phase 3 cutover):
- PostgreSQL DB name "capakraken" and POSTGRES_USER "capakraken"
- Volume names capakraken_pgdata etc.
- Compose project name "capakraken" / "capakraken-prod"
- db-target-guard default expectedDatabase
- env-var CAPAKRAKEN_EXPECTED_DB_NAME
- Container DNS names in docker-compose.ci.yml

Quality gates green: pnpm typecheck (7/7), pnpm test:unit (7/7),
pnpm lint (0 errors), check:exports/imports/architecture all pass.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-21 15:10:44 +02:00

150 lines
3.9 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from "vitest";
import { SystemRole } from "@nexus/shared";
import { createToolContext, executeTool } from "./assistant-tools-comments-test-helpers.js";
describe("assistant comment tools create errors", () => {
beforeEach(() => {
vi.clearAllMocks();
});
it("returns a stable assistant error when creating a comment with an empty body", async () => {
const ctx = createToolContext(
{
estimate: {
findUnique: vi.fn(),
},
comment: {
create: vi.fn(),
},
},
{ userRole: SystemRole.CONTROLLER },
);
const result = await executeTool(
"create_comment",
JSON.stringify({
entityType: "estimate",
entityId: "est_1",
body: "",
}),
ctx,
);
expect(JSON.parse(result.content)).toEqual({
error: "Comment body is required.",
});
expect(ctx.db.comment.create).not.toHaveBeenCalled();
});
it("returns a stable assistant error when creating a comment with a body that is too long", async () => {
const ctx = createToolContext(
{
estimate: {
findUnique: vi.fn(),
},
comment: {
create: vi.fn(),
},
},
{ userRole: SystemRole.CONTROLLER },
);
const result = await executeTool(
"create_comment",
JSON.stringify({
entityType: "estimate",
entityId: "est_1",
body: "x".repeat(10_001),
}),
ctx,
);
expect(JSON.parse(result.content)).toEqual({
error: "Comment body must be at most 10000 characters.",
});
expect(ctx.db.comment.create).not.toHaveBeenCalled();
});
it("returns a stable assistant error when the comment author disappears during creation", async () => {
const ctx = createToolContext(
{
estimate: {
findUnique: vi.fn().mockResolvedValue({ id: "est_1" }),
},
comment: {
create: vi.fn().mockRejectedValue({
code: "P2003",
message: "Foreign key constraint failed",
meta: { field_name: "Comment_authorId_fkey" },
}),
},
},
{ userRole: SystemRole.CONTROLLER },
);
const result = await executeTool(
"create_comment",
JSON.stringify({
entityType: "estimate",
entityId: "est_1",
body: "Please review this estimate.",
}),
ctx,
);
expect(JSON.parse(result.content)).toEqual({
error: "Comment author not found with the given criteria.",
});
});
it("returns a stable assistant error when a mentioned user disappears during comment creation", async () => {
const ctx = createToolContext(
{
estimate: {
findUnique: vi.fn().mockResolvedValue({ id: "est_1" }),
},
comment: {
create: vi.fn().mockResolvedValue({
id: "comment_created",
body: "Hello @[Peter Parker](user_missing)",
resolved: false,
createdAt: new Date("2026-03-29T11:00:00.000Z"),
author: {
id: "user_1",
name: "Assistant User",
email: "assistant@example.com",
image: null,
},
}),
},
notification: {
create: vi.fn().mockRejectedValue({
code: "P2003",
message: "Foreign key constraint failed",
meta: { field_name: "Notification_userId_fkey" },
}),
},
auditLog: {
create: vi.fn(),
},
},
{ userRole: SystemRole.CONTROLLER },
);
const result = await executeTool(
"create_comment",
JSON.stringify({
entityType: "estimate",
entityId: "est_1",
body: "Hello @[Peter Parker](user_missing)",
}),
ctx,
);
expect(JSON.parse(result.content)).toEqual({
error: "Mentioned user not found with the given criteria.",
});
});
});