2.0 KiB
2.0 KiB
Import Hardening
Date: 2026-03-30 Purpose: Define the safe parser boundary for untrusted spreadsheet imports.
Decision
- Untrusted workbook imports no longer accept legacy
.xls. - Server-side dispo imports accept only
.xlsxfiles. - Browser-side ad hoc imports accept
.xlsxand.csv. - Trusted export generation may still use
xlsxuntil the export paths are migrated separately.
Server Boundary
The dispo-import reader in read-workbook.ts now enforces:
- normalized filesystem paths before reading
- regular-file checks
- non-empty file checks
- a hard size limit of
15 MiB .xlsx-only parsing behind a hardened server-side parser boundary
The API entry points in dispo.ts reject non-.xlsx workbook paths before staging or validation begins.
Browser Boundary
The browser import helpers in excel.ts and skillMatrixParser.ts now enforce:
- a hard client-side file size limit of
10 MiB - explicit rejection of legacy
.xls .xlsxparsing throughexceljs.csvparsing through a local parser for simple tabular imports
Affected upload flows:
- resource CSV/XLSX import
- estimate scope spreadsheet import
- single skill-matrix import
- batch skill-matrix import
Rationale
.xlssupport keeps the old binary workbook format in the untrusted path without enough payoff.- the server path keeps compatibility-first
.xlsxparsing for the current dispo workbooks, but only behind explicit file validation and limits - the browser path moves away from blanket
xlsximport usage to a narrower parser boundary - CSV remains useful for lightweight business imports and is small enough to parse with a narrow local parser.